Change some fxbarcode to use return values.

No caller cares about the exception values anyway. Remove the unused
ones. Also use more std::unique_ptr to stop potential leaks.

Change-Id: Ic5955fb0d879f55e1c6a005c0204df50246dab19
Reviewed-on: https://pdfium-review.googlesource.com/3715
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

1 files changed, 7 insertions, 3 deletions

diff --git a/fxbarcode/oned/BC_OneDimWriter.cpp b/fxbarcode/oned/BC_OneDimWriter.cpp
index 95244ae614..f6b33f37a9 100644
--- a/fxbarcode/oned/BC_OneDimWriter.cpp
+++ b/fxbarcode/oned/BC_OneDimWriter.cpp
@@ -455,12 +455,16 @@ void CBC_OneDimWriter::RenderResult(const CFX_WideStringC& contents,
         break;
       }
       if (outputX + m_multiple > outputWidth && outputWidth - outputX > 0) {
-        m_output->SetRegion(outputX, 0, outputWidth - outputX, outputHeight, e);
+        if (!m_output->SetRegion(outputX, 0, outputWidth - outputX,
+                                 outputHeight)) {
+          e = BCExceptionGeneric;
+        }
         break;
       }
-      m_output->SetRegion(outputX, 0, m_multiple, outputHeight, e);
-      if (e != BCExceptionNO)
+      if (!m_output->SetRegion(outputX, 0, m_multiple, outputHeight)) {
+        e = BCExceptionGeneric;
         return;
+      }
     }
     outputX += m_multiple;
   }