diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-02-08 20:16:09 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-08 20:16:09 +0000 |
| commit | b3f1046cb2c9bb7fc2a2579b76c8e65b24323002 (patch) | |
| tree | c687a105ebece091f5a2386f88855c163ba7e6cc /fxjs/JS_Define.cpp | |
| parent | f0e386de64e030f6d692acfa27e2bc0a50018710 (diff) | |
| download | pdfium-b3f1046cb2c9bb7fc2a2579b76c8e65b24323002.tar.xz | |
Make CFXJS_Engine::SetObjectPrivate() static.
Avoids call to CFXJS_Engine::EngineFromIsolateCurrentContext() during
the Dispose() path, which feels scary because there aren't guarantees
about it having an engine at isolate "dispose" time. Fortunately, |this|
is not used, so make that fact clear.
Replace some c-style callbacks with std::function while we're at it.
Change-Id: Ia1a1a1fcc085d8657939e6f8c8d34fc511afddfe
Reviewed-on: https://pdfium-review.googlesource.com/25970
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs/JS_Define.cpp')
| -rw-r--r-- | fxjs/JS_Define.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fxjs/JS_Define.cpp b/fxjs/JS_Define.cpp index 744cb7dd77..d5b1cefeda 100644 --- a/fxjs/JS_Define.cpp +++ b/fxjs/JS_Define.cpp @@ -167,8 +167,8 @@ int DateFromTime(double t) { } // namespace -void JSDestructor(CFXJS_Engine* pEngine, v8::Local<v8::Object> obj) { - pEngine->SetObjectPrivate(obj, nullptr); +void JSDestructor(v8::Local<v8::Object> obj) { + CFXJS_Engine::SetObjectPrivate(obj, nullptr); } double JS_GetDateTime() { |