diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2018-05-17 13:53:52 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-05-17 13:53:52 +0000 |
| commit | dc5d88bcebbeeb696b405464e901add55d1efaf7 (patch) | |
| tree | 54bc913015ea4d08b9fe46997f25a3153cbc70d7 /fxjs/cfxjs_engine_unittest.cpp | |
| parent | db3c6cefceddf25c25f1205d7b633f09e873bf98 (diff) | |
| download | pdfium-dc5d88bcebbeeb696b405464e901add55d1efaf7.tar.xz | |
Convert JS execute methods to return Optional<IJS_Runtime::JS_Error>
This CL changes several of the JS execution methods to to return an
Optional<IJS_Runtime::JS_Error> instead of a bool with a WideString
out param.
The IJS_Runtime::JS_Error will contain the line, column and exception message
if an error occurs during execution.
Change-Id: I37785ae6cd133a4c94ad8d25289473600b8a5d19
Reviewed-on: https://pdfium-review.googlesource.com/32614
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/cfxjs_engine_unittest.cpp')
| -rw-r--r-- | fxjs/cfxjs_engine_unittest.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fxjs/cfxjs_engine_unittest.cpp b/fxjs/cfxjs_engine_unittest.cpp index d5c473c178..5b93072935 100644 --- a/fxjs/cfxjs_engine_unittest.cpp +++ b/fxjs/cfxjs_engine_unittest.cpp @@ -79,8 +79,9 @@ TEST_F(FXJSEngineUnitTest, GC) { EXPECT_FALSE(temp_destroyed); } - FXJSErr error; - engine()->Execute(L"gc();", &error); + Optional<IJS_Runtime::JS_Error> err = engine()->Execute(L"gc();"); + EXPECT_FALSE(err); + EXPECT_TRUE(perm_created); EXPECT_FALSE(perm_destroyed); EXPECT_TRUE(temp_created); |