diff options
| author | Adam Klein <adamk@chromium.org> | 2018-01-17 21:06:27 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-01-17 21:06:27 +0000 |
| commit | 4c451ba43b19c2679467bbb7d7502b3596224038 (patch) | |
| tree | 9792633226d49234499132db0d1560b2f4459c1e /fxjs/cfxjse_class.cpp | |
| parent | d859d5745b0a5da010ada6ee512841e1f4394ec6 (diff) | |
| download | pdfium-4c451ba43b19c2679467bbb7d7502b3596224038.tar.xz | |
Pass Isolate to v8::String::Utf8Value API
The non-Isolate version will soon be deprecated.
Bug: v8:7269, v8:7282
Change-Id: I204e45bd73f5b809d6c44b77bbcf62d32e7ccbec
Reviewed-on: https://pdfium-review.googlesource.com/23058
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Diffstat (limited to 'fxjs/cfxjse_class.cpp')
| -rw-r--r-- | fxjs/cfxjse_class.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fxjs/cfxjse_class.cpp b/fxjs/cfxjse_class.cpp index 9515ef4b74..dd2181b853 100644 --- a/fxjs/cfxjse_class.cpp +++ b/fxjs/cfxjse_class.cpp @@ -81,7 +81,7 @@ void DynPropGetterAdapter_MethodCallback( hCallBackInfo->GetInternalField(1).As<v8::String>(); ASSERT(lpClass && !hPropName.IsEmpty()); - v8::String::Utf8Value szPropName(hPropName); + v8::String::Utf8Value szPropName(info.GetIsolate(), hPropName); WideString szFxPropName = WideString::FromUTF8(*szPropName); CJS_Return result = lpClass->dynMethodCall(info, szFxPropName); @@ -168,7 +168,7 @@ void NamedPropertyQueryCallback( info.Data().As<v8::External>()->Value()); v8::Isolate* pIsolate = info.GetIsolate(); v8::HandleScope scope(pIsolate); - v8::String::Utf8Value szPropName(property); + v8::String::Utf8Value szPropName(pIsolate, property); ByteStringView szFxPropName(*szPropName, szPropName.length()); auto lpThisValue = pdfium::MakeUnique<CFXJSE_Value>(info.GetIsolate()); lpThisValue->ForceSetValue(thisObject); @@ -186,7 +186,7 @@ void NamedPropertyGetterCallback( v8::Local<v8::Object> thisObject = info.Holder(); const FXJSE_CLASS_DESCRIPTOR* lpClass = static_cast<FXJSE_CLASS_DESCRIPTOR*>( info.Data().As<v8::External>()->Value()); - v8::String::Utf8Value szPropName(property); + v8::String::Utf8Value szPropName(info.GetIsolate(), property); ByteStringView szFxPropName(*szPropName, szPropName.length()); auto lpThisValue = pdfium::MakeUnique<CFXJSE_Value>(info.GetIsolate()); lpThisValue->ForceSetValue(thisObject); @@ -203,7 +203,7 @@ void NamedPropertySetterCallback( v8::Local<v8::Object> thisObject = info.Holder(); const FXJSE_CLASS_DESCRIPTOR* lpClass = static_cast<FXJSE_CLASS_DESCRIPTOR*>( info.Data().As<v8::External>()->Value()); - v8::String::Utf8Value szPropName(property); + v8::String::Utf8Value szPropName(info.GetIsolate(), property); ByteStringView szFxPropName(*szPropName, szPropName.length()); auto lpThisValue = pdfium::MakeUnique<CFXJSE_Value>(info.GetIsolate()); lpThisValue->ForceSetValue(thisObject); |