diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-04-05 22:41:53 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-04-05 22:41:53 +0000 |
| commit | 4862705090a7469115ae7e3c80143b6f8b6b527a (patch) | |
| tree | a7894aa174e3621bfa15e4070e418ee2b1f01f31 /fxjs/cfxjse_engine.cpp | |
| parent | 0c5928825d0bc0c397e90d2c4861feaf9bdc6d24 (diff) | |
| download | pdfium-4862705090a7469115ae7e3c80143b6f8b6b527a.tar.xz | |
Make Internal field usage in cfxjs_engine match README.doc
As it turns out, this doesn't cause any bugs with the FXJS/FXJSE
interaction since the magic values will never be present in the
other slot, but the code looks wrong wrt. the document.
Also fix an assert in FXJSE that our objects have two slots,
and null appropriately (just a defensive measure).
Also assert that one of our casts is valid.
Change-Id: I3146fe58350da5e9b76e711d81480565dabd587f
Reviewed-on: https://pdfium-review.googlesource.com/29859
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/cfxjse_engine.cpp')
| -rw-r--r-- | fxjs/cfxjse_engine.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fxjs/cfxjse_engine.cpp b/fxjs/cfxjse_engine.cpp index c634c72a43..f0c522f018 100644 --- a/fxjs/cfxjse_engine.cpp +++ b/fxjs/cfxjse_engine.cpp @@ -31,8 +31,6 @@ #include "xfa/fxfa/parser/xfa_resolvenode_rs.h" #include "xfa/fxfa/parser/xfa_utils.h" -namespace { - const FXJSE_CLASS_DESCRIPTOR GlobalClassDescriptor = { "Root", // name nullptr, // methods @@ -63,6 +61,8 @@ const FXJSE_CLASS_DESCRIPTOR VariablesClassDescriptor = { CFXJSE_Engine::NormalMethodCall, }; +namespace { + const char kFormCalcRuntime[] = "pfm_rt"; CXFA_ThisProxy* ToThisProxy(CFXJSE_Value* pValue, CFXJSE_Class* pClass) { |