diff options
author | Tom Sepez <tsepez@chromium.org> | 2018-07-24 16:29:25 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-07-24 16:29:25 +0000 |
commit | c9f1234b1982eb7ec8a5254195574e88bee54703 (patch) | |
tree | cdc8831de3fae8d571646c29bad3da80cd63799c /fxjs/cfxjse_engine.cpp | |
parent | aa50728980036f07fda232cea974fd80c89b7cb7 (diff) | |
download | pdfium-c9f1234b1982eb7ec8a5254195574e88bee54703.tar.xz |
Remove lpClass argument from FXJSE_RetrieveObjectBinding()
In turn, it too is always nullptr. This shows that the V8
side check for hasInstance() was never being applied. We will
augment this with C++ side checks down the road, since we don't
want to trust V8 anyways.
Change-Id: Iee38f32af9561783dbf253d798bd975029f3a4a2
Reviewed-on: https://pdfium-review.googlesource.com/38594
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/cfxjse_engine.cpp')
-rw-r--r-- | fxjs/cfxjse_engine.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fxjs/cfxjse_engine.cpp b/fxjs/cfxjse_engine.cpp index c5cc89a8d0..e297ed16e2 100644 --- a/fxjs/cfxjse_engine.cpp +++ b/fxjs/cfxjse_engine.cpp @@ -81,7 +81,7 @@ CXFA_Object* CFXJSE_Engine::ToObject( return nullptr; CFXJSE_HostObject* pHostObj = - FXJSE_RetrieveObjectBinding(info.Holder().As<v8::Object>(), nullptr); + FXJSE_RetrieveObjectBinding(info.Holder().As<v8::Object>()); return pHostObj ? pHostObj->AsCXFAObject() : nullptr; } @@ -793,7 +793,7 @@ CXFA_Object* CFXJSE_Engine::ToXFAObject(v8::Local<v8::Value> obj) { return nullptr; CFXJSE_HostObject* pHostObj = - FXJSE_RetrieveObjectBinding(obj.As<v8::Object>(), nullptr); + FXJSE_RetrieveObjectBinding(obj.As<v8::Object>()); return pHostObj ? pHostObj->AsCXFAObject() : nullptr; } |