diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-08-21 22:56:37 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-08-21 22:56:37 +0000 |
| commit | 1a3e186e975aa8eb6a6e42f2626b6f8ca980db19 (patch) | |
| tree | cd9817ce3e5730a2b3efb36ccca253d5ecddac48 /fxjs/cfxjse_formcalc_context.cpp | |
| parent | f47444256898ed42e01accffa9c97a4dd82c9013 (diff) | |
| download | pdfium-1a3e186e975aa8eb6a6e42f2626b6f8ca980db19.tar.xz | |
Use UnownedPtr<> in xfa_resolvenode_rs.h
Change-Id: I4420fbf7402a8b08e33ca525e98690643d59efdf
Reviewed-on: https://pdfium-review.googlesource.com/40930
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/cfxjse_formcalc_context.cpp')
| -rw-r--r-- | fxjs/cfxjse_formcalc_context.cpp | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/fxjs/cfxjse_formcalc_context.cpp b/fxjs/cfxjse_formcalc_context.cpp index 0eee3d4de5..34f5642844 100644 --- a/fxjs/cfxjse_formcalc_context.cpp +++ b/fxjs/cfxjse_formcalc_context.cpp @@ -5904,7 +5904,7 @@ bool CFXJSE_FormCalcContext::GetObjectForName( dwFlags, nullptr); if (iRet && resolveNodeRS.dwFlags == XFA_ResolveNode_RSType_Nodes) { accessorValue->Assign( - pScriptContext->GetJSValueFromMap(resolveNodeRS.objects.front())); + pScriptContext->GetJSValueFromMap(resolveNodeRS.objects.front().Get())); return true; } return false; @@ -5979,9 +5979,10 @@ void CFXJSE_FormCalcContext::ParseResolveResult( if (resolveNodeRS.dwFlags == XFA_ResolveNode_RSType_Nodes) { *bAttribute = false; CFXJSE_Engine* pScriptContext = pContext->GetDocument()->GetScriptContext(); - for (CXFA_Object* pObject : resolveNodeRS.objects) { + for (auto& pObject : resolveNodeRS.objects) { resultValues->push_back(pdfium::MakeUnique<CFXJSE_Value>(pIsolate)); - resultValues->back()->Assign(pScriptContext->GetJSValueFromMap(pObject)); + resultValues->back()->Assign( + pScriptContext->GetJSValueFromMap(pObject.Get())); } return; } @@ -5989,7 +5990,7 @@ void CFXJSE_FormCalcContext::ParseResolveResult( *bAttribute = true; if (resolveNodeRS.pScriptAttribute && resolveNodeRS.pScriptAttribute->eValueType == XFA_ScriptType::Object) { - for (CXFA_Object* pObject : resolveNodeRS.objects) { + for (auto& pObject : resolveNodeRS.objects) { auto pValue = pdfium::MakeUnique<CFXJSE_Value>(pIsolate); CJX_Object* jsObject = pObject->JSObject(); (jsObject->*(resolveNodeRS.pScriptAttribute->callback))( |