diff options
| author | weili <weili@chromium.org> | 2016-08-19 14:09:33 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-08-19 14:09:33 -0700 |
| commit | ad589d7b83768f3b78ae6b9c90aa418611cc12c2 (patch) | |
| tree | fe7d05842dfb43e738506b2f436eb0a27da73276 /fxjs/cfxjse_isolatetracker.cpp | |
| parent | 5b13e1dc5770b73295f0c4a61c699a10eb7922e6 (diff) | |
| download | pdfium-ad589d7b83768f3b78ae6b9c90aa418611cc12c2.tar.xz | |
Fix leaked array buffer allocators of isolates
The array buffer allocators are allocated and owned by pdfium code,
they should be deleted properly after the corresponding isolates are
disposed.
BUG=pdfium:242
Review-Url: https://codereview.chromium.org/2254123004
Diffstat (limited to 'fxjs/cfxjse_isolatetracker.cpp')
| -rw-r--r-- | fxjs/cfxjse_isolatetracker.cpp | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/fxjs/cfxjse_isolatetracker.cpp b/fxjs/cfxjse_isolatetracker.cpp index 9594df3109..adf6f2a92e 100644 --- a/fxjs/cfxjse_isolatetracker.cpp +++ b/fxjs/cfxjse_isolatetracker.cpp @@ -12,8 +12,11 @@ CFXJSE_IsolateTracker::CFXJSE_IsolateTracker() {} CFXJSE_IsolateTracker::~CFXJSE_IsolateTracker() {} -void CFXJSE_IsolateTracker::Append(v8::Isolate* pIsolate) { +void CFXJSE_IsolateTracker::Append( + v8::Isolate* pIsolate, + std::unique_ptr<v8::ArrayBuffer::Allocator> alloc) { m_OwnedIsolates.push_back(pIsolate); + m_AllocatorMap[pIsolate] = std::move(alloc); } void CFXJSE_IsolateTracker::Remove( @@ -24,6 +27,8 @@ void CFXJSE_IsolateTracker::Remove( if (bFound) m_OwnedIsolates.erase(it); lpfnDisposeCallback(pIsolate, bFound); + + m_AllocatorMap.erase(pIsolate); } void CFXJSE_IsolateTracker::RemoveAll( @@ -32,4 +37,5 @@ void CFXJSE_IsolateTracker::RemoveAll( lpfnDisposeCallback(pIsolate, true); m_OwnedIsolates.clear(); + m_AllocatorMap.clear(); } |