diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-04-11 21:11:28 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-04-11 21:11:28 +0000 |
| commit | 1e934f6868465bca960f9f13489489ba1d649581 (patch) | |
| tree | 36df9044ccd3327d3d60fb43ac523e2bc260cca6 /fxjs/cjs_document.cpp | |
| parent | 4796acb896dabefe6d9a2dbe6d8a61ff7e086dfd (diff) | |
| download | pdfium-1e934f6868465bca960f9f13489489ba1d649581.tar.xz | |
Remove use of GetBuffer()/ReleaseBuffer() when c_str() is sufficient.
Greatly simplify the code which was neither changing allocations nor
doing any actual work. Eventually GetBuffer() will return a span, and
this makes fewer places to change.
Comment AsFPDFWideString() as a place where we may want a redundant
copy, and make available outside the .cpp file.
Fix one "const" along the way.
Change-Id: I187758b69a0ba3501b3622f6c06280793cd5d464
Reviewed-on: https://pdfium-review.googlesource.com/30011
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/cjs_document.cpp')
| -rw-r--r-- | fxjs/cjs_document.cpp | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fxjs/cjs_document.cpp b/fxjs/cjs_document.cpp index 83711e1b28..2a36b61a4a 100644 --- a/fxjs/cjs_document.cpp +++ b/fxjs/cjs_document.cpp @@ -942,11 +942,9 @@ CJS_Return CJS_Document::get_document_file_name(CJS_Runtime* pRuntime) { if (wsFilePath[i - 1] == L'\\' || wsFilePath[i - 1] == L'/') break; } + if (i > 0 && i < wsFilePath.GetLength()) + return CJS_Return(pRuntime->NewString(wsFilePath.c_str() + i)); - if (i > 0 && i < wsFilePath.GetLength()) { - return CJS_Return( - pRuntime->NewString(wsFilePath.GetBuffer(wsFilePath.GetLength()) + i)); - } return CJS_Return(pRuntime->NewString(L"")); } |