summaryrefslogtreecommitdiff
path: root/fxjs/cjs_field.h
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-06-04 19:44:37 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-06-04 19:44:37 +0000
commit36aae4fc09a353e01738bf0bbc302a21ba21ed07 (patch)
tree2d9d1cbe2f7c8eeed7aff9fc63a8f8300a25d6b7 /fxjs/cjs_field.h
parent9d3fb11a985a8f2aefbf361c0030c7bce2248b8e (diff)
downloadpdfium-36aae4fc09a353e01738bf0bbc302a21ba21ed07.tar.xz
Make CJS_Objects track CJS_Runtime (and hence the document itself)
Precursor to removing some more v8::Context slot dependency. There's a cost to maintaining the set of observers, but since these objects are tied to V8 lifetimes, not C++ lifetimes, we want to be very wary of the document going away unexpectedly. Change-Id: I579f58a460aa50b88cb861227c9aca9a8a83ce12 Reviewed-on: https://pdfium-review.googlesource.com/33471 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs/cjs_field.h')
-rw-r--r--fxjs/cjs_field.h13
1 files changed, 5 insertions, 8 deletions
diff --git a/fxjs/cjs_field.h b/fxjs/cjs_field.h
index 51cc530efa..ba476139cf 100644
--- a/fxjs/cjs_field.h
+++ b/fxjs/cjs_field.h
@@ -34,12 +34,9 @@ class CJS_Field : public CJS_Object {
static void DoDelay(CPDFSDK_FormFillEnvironment* pFormFillEnv,
CJS_DelayData* pData);
- explicit CJS_Field(v8::Local<v8::Object> pObject);
+ CJS_Field(v8::Local<v8::Object> pObject, CJS_Runtime* pRuntime);
~CJS_Field() override;
- // CJS_Object
- void InitInstance(IJS_Runtime* pIRuntime) override;
-
bool AttachField(CJS_Document* pDocument, const WideString& csFieldName);
JS_STATIC_PROP(alignment, alignment, CJS_Field);
@@ -421,12 +418,12 @@ class CJS_Field : public CJS_Object {
void DoDelay();
- CJS_Document* m_pJSDoc;
+ CJS_Document* m_pJSDoc = nullptr;
CPDFSDK_FormFillEnvironment::ObservedPtr m_pFormFillEnv;
WideString m_FieldName;
- int m_nFormControlIndex;
- bool m_bCanSet;
- bool m_bDelay;
+ int m_nFormControlIndex = -1;
+ bool m_bCanSet = false;
+ bool m_bDelay = false;
};
#endif // FXJS_CJS_FIELD_H_