diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2018-02-05 21:43:19 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-05 21:43:19 +0000 |
| commit | 998fee395fc8a543968c7db3db9e3cf81dee57fc (patch) | |
| tree | c11024354ed996cee5cd5d463ab050e1e2c02d5d /fxjs/cjs_global.cpp | |
| parent | 0729be26d745e2ea713908eb9040e2be7c40c96b (diff) | |
| download | pdfium-998fee395fc8a543968c7db3db9e3cf81dee57fc.tar.xz | |
Remove the CJS_EmbedObj template param from JSConstructor.
Each of the CJS_Objects can create their CJS_EmbedObj's internally and
we don't need to do it though the JSConstructor. This also removes the
need for the SetEmbedObj method in CJS_Object.
Change-Id: Ib0535ad922b370634fd1e622a04860a96c4f2825
Reviewed-on: https://pdfium-review.googlesource.com/25370
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs/cjs_global.cpp')
| -rw-r--r-- | fxjs/cjs_global.cpp | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/fxjs/cjs_global.cpp b/fxjs/cjs_global.cpp index 0326516f1b..8816cf1b07 100644 --- a/fxjs/cjs_global.cpp +++ b/fxjs/cjs_global.cpp @@ -222,12 +222,15 @@ void CJS_Global::DefineAllProperties(CFXJS_Engine* pEngine) { // static void CJS_Global::DefineJSObjects(CFXJS_Engine* pEngine) { ObjDefnID = pEngine->DefineObj("global", FXJSOBJTYPE_STATIC, - JSConstructor<CJS_Global, JSGlobalAlternate>, - JSDestructor); + JSConstructor<CJS_Global>, JSDestructor); DefineMethods(pEngine, ObjDefnID, MethodSpecs, FX_ArraySize(MethodSpecs)); DefineAllProperties(pEngine); } +CJS_Global::CJS_Global(v8::Local<v8::Object> pObject) : CJS_Object(pObject) { + m_pEmbedObj = pdfium::MakeUnique<JSGlobalAlternate>(this); +} + void CJS_Global::InitInstance(IJS_Runtime* pIRuntime) { CJS_Runtime* pRuntime = static_cast<CJS_Runtime*>(pIRuntime); JSGlobalAlternate* pGlobal = |