summaryrefslogtreecommitdiff
path: root/fxjs/cjs_global.cpp
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-07-16 22:17:46 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-07-16 22:17:46 +0000
commit82999fa9d685638561efc6df2c8370c7e7f47676 (patch)
treedecf3cacc87bb0a0c7481d10ce7a2b1c11729a56 /fxjs/cjs_global.cpp
parentf9d49da715deeb0efa6eaaf8ac43727ae28f8749 (diff)
downloadpdfium-82999fa9d685638561efc6df2c8370c7e7f47676.tar.xz
Make JSGetObject<C>() return UnownedPtr<C>.
This a convenient place to assert that the callback that is about to be invoked on the object doesn't destroy the object at any point during its execution. Change-Id: Iacb9d4e01603cc6bf316b00fdd062955c903ca5c Reviewed-on: https://pdfium-review.googlesource.com/37970 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'fxjs/cjs_global.cpp')
-rw-r--r--fxjs/cjs_global.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/fxjs/cjs_global.cpp b/fxjs/cjs_global.cpp
index c9afdcb8b8..efeef56b08 100644
--- a/fxjs/cjs_global.cpp
+++ b/fxjs/cjs_global.cpp
@@ -32,7 +32,7 @@ template <class Alt>
void JSSpecialPropQuery(const char*,
v8::Local<v8::String> property,
const v8::PropertyCallbackInfo<v8::Integer>& info) {
- Alt* pObj = JSGetObject<Alt>(info.Holder());
+ auto pObj = JSGetObject<Alt>(info.Holder());
if (!pObj)
return;
@@ -50,7 +50,7 @@ template <class Alt>
void JSSpecialPropGet(const char* class_name,
v8::Local<v8::String> property,
const v8::PropertyCallbackInfo<v8::Value>& info) {
- Alt* pObj = JSGetObject<Alt>(info.Holder());
+ auto pObj = JSGetObject<Alt>(info.Holder());
if (!pObj)
return;
@@ -75,7 +75,7 @@ void JSSpecialPropPut(const char* class_name,
v8::Local<v8::String> property,
v8::Local<v8::Value> value,
const v8::PropertyCallbackInfo<v8::Value>& info) {
- Alt* pObj = JSGetObject<Alt>(info.Holder());
+ auto pObj = JSGetObject<Alt>(info.Holder());
if (!pObj)
return;
@@ -96,7 +96,7 @@ template <class Alt>
void JSSpecialPropDel(const char* class_name,
v8::Local<v8::String> property,
const v8::PropertyCallbackInfo<v8::Boolean>& info) {
- Alt* pObj = JSGetObject<Alt>(info.Holder());
+ auto pObj = JSGetObject<Alt>(info.Holder());
if (!pObj)
return;