summaryrefslogtreecommitdiff
path: root/fxjs/cjs_icon.h
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-06-04 19:44:37 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-06-04 19:44:37 +0000
commit36aae4fc09a353e01738bf0bbc302a21ba21ed07 (patch)
tree2d9d1cbe2f7c8eeed7aff9fc63a8f8300a25d6b7 /fxjs/cjs_icon.h
parent9d3fb11a985a8f2aefbf361c0030c7bce2248b8e (diff)
downloadpdfium-36aae4fc09a353e01738bf0bbc302a21ba21ed07.tar.xz
Make CJS_Objects track CJS_Runtime (and hence the document itself)
Precursor to removing some more v8::Context slot dependency. There's a cost to maintaining the set of observers, but since these objects are tied to V8 lifetimes, not C++ lifetimes, we want to be very wary of the document going away unexpectedly. Change-Id: I579f58a460aa50b88cb861227c9aca9a8a83ce12 Reviewed-on: https://pdfium-review.googlesource.com/33471 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs/cjs_icon.h')
-rw-r--r--fxjs/cjs_icon.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/fxjs/cjs_icon.h b/fxjs/cjs_icon.h
index a346d69e73..2f3ee3f86f 100644
--- a/fxjs/cjs_icon.h
+++ b/fxjs/cjs_icon.h
@@ -14,7 +14,7 @@ class CJS_Icon : public CJS_Object {
static int GetObjDefnID();
static void DefineJSObjects(CFXJS_Engine* pEngine);
- explicit CJS_Icon(v8::Local<v8::Object> pObject);
+ CJS_Icon(v8::Local<v8::Object> pObject, CJS_Runtime* pRuntime);
~CJS_Icon() override;
WideString GetIconName() const { return m_swIconName; }