summaryrefslogtreecommitdiff
path: root/fxjs/cjs_object.cpp
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-06-11 15:55:17 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-06-11 15:55:17 +0000
commit8b4ddebff061b199f14684f17cac8915bade8fb2 (patch)
treee8b1f18bec5c1377dfe5a0967e2e6f78c3df9812 /fxjs/cjs_object.cpp
parent9bc7a213b95439ab91183ac6684bf01e09ae60c1 (diff)
downloadpdfium-8b4ddebff061b199f14684f17cac8915bade8fb2.tar.xz
Use spans in CJS_Object.
Avoid explicitly having to count items in arrays. Change-Id: I24a91db45e8a8530f38afcc273e824ffb70a6cb9 Reviewed-on: https://pdfium-review.googlesource.com/34710 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs/cjs_object.cpp')
-rw-r--r--fxjs/cjs_object.cpp29
1 files changed, 12 insertions, 17 deletions
diff --git a/fxjs/cjs_object.cpp b/fxjs/cjs_object.cpp
index 36fcc744d1..e30f6b4070 100644
--- a/fxjs/cjs_object.cpp
+++ b/fxjs/cjs_object.cpp
@@ -9,35 +9,30 @@
// static
void CJS_Object::DefineConsts(CFXJS_Engine* pEngine,
int objId,
- const JSConstSpec consts[],
- size_t count) {
- for (size_t i = 0; i < count; ++i) {
+ pdfium::span<const JSConstSpec> consts) {
+ for (const auto& item : consts) {
pEngine->DefineObjConst(
- objId, consts[i].pName,
- consts[i].eType == JSConstSpec::Number
- ? pEngine->NewNumber(consts[i].number).As<v8::Value>()
- : pEngine->NewString(consts[i].pStr).As<v8::Value>());
+ objId, item.pName,
+ item.eType == JSConstSpec::Number
+ ? pEngine->NewNumber(item.number).As<v8::Value>()
+ : pEngine->NewString(item.pStr).As<v8::Value>());
}
}
// static
void CJS_Object::DefineProps(CFXJS_Engine* pEngine,
int objId,
- const JSPropertySpec props[],
- size_t count) {
- for (size_t i = 0; i < count; ++i) {
- pEngine->DefineObjProperty(objId, props[i].pName, props[i].pPropGet,
- props[i].pPropPut);
- }
+ pdfium::span<const JSPropertySpec> props) {
+ for (const auto& item : props)
+ pEngine->DefineObjProperty(objId, item.pName, item.pPropGet, item.pPropPut);
}
// static
void CJS_Object::DefineMethods(CFXJS_Engine* pEngine,
int objId,
- const JSMethodSpec methods[],
- size_t count) {
- for (size_t i = 0; i < count; ++i)
- pEngine->DefineObjMethod(objId, methods[i].pName, methods[i].pMethodCall);
+ pdfium::span<const JSMethodSpec> methods) {
+ for (const auto& item : methods)
+ pEngine->DefineObjMethod(objId, item.pName, item.pMethodCall);
}
CJS_Object::CJS_Object(v8::Local<v8::Object> pObject, CJS_Runtime* pRuntime)