diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2018-03-12 14:17:54 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-03-12 14:17:54 +0000 |
| commit | c2df008640f56631735dd3ae89e118c9c56cd36d (patch) | |
| tree | 93276050cbd5467a63d72ce2b887c64d48341a67 /fxjs/cjs_publicmethods.cpp | |
| parent | 0e2e8db7e6e87611d4137e20a614761a3bc0b676 (diff) | |
| download | pdfium-c2df008640f56631735dd3ae89e118c9c56cd36d.tar.xz | |
Handle inserting negative values without a selection
When handling the AFNumber_Keystroke callback, if the changed value is
negative and there is no selection, we'd incorrectly error out thinking
we were inserting before the negative sign.
This CL checks if the selection string is empty before erroring out.
Bug: chromium:817433
Change-Id: I0ca08e121e9a8c207e9c7793f5b8a4e795c135e6
Reviewed-on: https://pdfium-review.googlesource.com/28110
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Diffstat (limited to 'fxjs/cjs_publicmethods.cpp')
| -rw-r--r-- | fxjs/cjs_publicmethods.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fxjs/cjs_publicmethods.cpp b/fxjs/cjs_publicmethods.cpp index d613f4888a..28df0a305b 100644 --- a/fxjs/cjs_publicmethods.cpp +++ b/fxjs/cjs_publicmethods.cpp @@ -1009,8 +1009,8 @@ CJS_Return CJS_PublicMethods::AFNumber_Keystroke( bool bHasSign = wstrValue.Contains(L'-') && !wstrSelected.Contains(L'-'); if (bHasSign) { - // can't insert "change" in front to sign postion. - if (pEvent->SelStart() == 0) { + // can't insert "change" in front of sign position. + if (!wstrSelected.IsEmpty() && pEvent->SelStart() == 0) { pEvent->Rc() = false; return CJS_Return(true); } |