Ensure CJS_Return() with error always includes a message.

Change the signature of the constructors to make it impossible to
do this otherwise.

Change-Id: I14e88d98a1128f2d599459ce9337cd6d079469fe
Reviewed-on: https://pdfium-review.googlesource.com/34531
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

1 files changed, 5 insertions, 5 deletions

diff --git a/fxjs/cjs_return.h b/fxjs/cjs_return.h
index 37c91caafe..df3c8519bd 100644
--- a/fxjs/cjs_return.h
+++ b/fxjs/cjs_return.h
@@ -8,12 +8,14 @@
 #define FXJS_CJS_RETURN_H_
 
 #include "fxjs/cfxjs_engine.h"
+#include "fxjs/js_resources.h"
 
 class CJS_Return {
  public:
-  explicit CJS_Return(bool);
-  explicit CJS_Return(const WideString&);
-  explicit CJS_Return(v8::Local<v8::Value>);
+  CJS_Return();                               // Successful but empty return.
+  explicit CJS_Return(v8::Local<v8::Value>);  // Successful return with value.
+  explicit CJS_Return(const WideString&);     // Error with custom message.
+  explicit CJS_Return(JSMessage id);          // Error with stock message.
   CJS_Return(const CJS_Return&);
   ~CJS_Return();
 
@@ -24,8 +26,6 @@ class CJS_Return {
   v8::Local<v8::Value> Return() const { return return_; }
 
  private:
-  CJS_Return() = delete;
-
   bool is_error_ = false;
   WideString error_;
   v8::Local<v8::Value> return_;