summaryrefslogtreecommitdiff
path: root/fxjs/cjs_v8.h
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-02-02 17:37:37 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-02-02 17:37:37 +0000
commit1258f7f21725c703269581e0241fbad86d89209c (patch)
tree4b065d6c432ee9e23995cab693a9eab73fbddfa1 /fxjs/cjs_v8.h
parent9cbd2dd8ff0812aae57a99d6a7dc285cc8b9e262 (diff)
downloadpdfium-1258f7f21725c703269581e0241fbad86d89209c.tar.xz
Remove V8 context from CJS_V8
Makes CFXJS_Engine and CFXJSE_Engine consistent with each other in that both have a V8 context to themselves, and not one inheritted from the CJS_V8 (which is now more per-isolate than per-context). Consolidate NewLocalContext() and GetPersistentContext(), which both did the exact same thing under the covers once inside v8 land. Rename a few things to make it simpler. Change-Id: I68905db9ad44253063da235fcb276a75627a2dbc Reviewed-on: https://pdfium-review.googlesource.com/25170 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/cjs_v8.h')
-rw-r--r--fxjs/cjs_v8.h9
1 files changed, 0 insertions, 9 deletions
diff --git a/fxjs/cjs_v8.h b/fxjs/cjs_v8.h
index b79d236670..1dd4953caa 100644
--- a/fxjs/cjs_v8.h
+++ b/fxjs/cjs_v8.h
@@ -28,9 +28,6 @@ class CJS_V8 {
v8::Isolate* GetIsolate() const { return m_isolate; }
- v8::Local<v8::Context> NewLocalContext();
- v8::Local<v8::Context> GetPersistentContext();
-
v8::Local<v8::Value> NewNull();
v8::Local<v8::Value> NewUndefined();
v8::Local<v8::Array> NewArray();
@@ -79,15 +76,9 @@ class CJS_V8 {
void SetIsolate(v8::Isolate* pIsolate) { m_isolate = pIsolate; }
void ClearConstArray() { m_ConstArrays.clear(); }
- void ResetPersistentContext(v8::Local<v8::Context> context) {
- m_V8PersistentContext.Reset(m_isolate, context);
- }
- void ReleasePersistentContext() { m_V8PersistentContext.Reset(); }
-
private:
v8::Isolate* m_isolate;
std::map<WideString, v8::Global<v8::Array>> m_ConstArrays;
- v8::Global<v8::Context> m_V8PersistentContext;
};
#endif // FXJS_CJS_V8_H_