Do not try to v8::Object::Clone() any objects

v8::Object::Clone() is deprecated, and gets us into trouble with
some corner cases.  Create a new handle to the same object instead.

Remove FXJS_NewObject() and FXJS_NewObject2(), and replace with
direct assignments.  Pass isolate to FXJS_NewNull() while were
at it, even though not needed, for consistency with all remaining
FXJS_New*() calls.

BUG=628106
R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2151023002

1 files changed, 1 insertions, 15 deletions

diff --git a/fxjs/fxjs_v8.cpp b/fxjs/fxjs_v8.cpp
index c98de070ab..8595ac8a71 100644
--- a/fxjs/fxjs_v8.cpp
+++ b/fxjs/fxjs_v8.cpp
@@ -779,25 +779,11 @@ v8::Local<v8::Value> FXJS_NewBoolean(v8::Isolate* pIsolate, bool b) {
   return v8::Boolean::New(pIsolate, b);
 }
 
-v8::Local<v8::Value> FXJS_NewObject(v8::Isolate* pIsolate,
-                                    v8::Local<v8::Object> pObj) {
-  if (pObj.IsEmpty())
-    return v8::Local<v8::Value>();
-  return pObj->Clone();
-}
-
-v8::Local<v8::Value> FXJS_NewObject2(v8::Isolate* pIsolate,
-                                     v8::Local<v8::Array> pObj) {
-  if (pObj.IsEmpty())
-    return v8::Local<v8::Value>();
-  return pObj->Clone();
-}
-
 v8::Local<v8::Value> FXJS_NewString(v8::Isolate* pIsolate, const wchar_t* str) {
   return FXJS_WSToJSString(pIsolate, str);
 }
 
-v8::Local<v8::Value> FXJS_NewNull() {
+v8::Local<v8::Value> FXJS_NewNull(v8::Isolate* pIsolate) {
   return v8::Local<v8::Value>();
 }