diff options
| author | dan sinclair <dsinclair@chromium.org> | 2017-10-24 21:46:57 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-10-25 18:14:23 +0000 |
| commit | 5daf07afe5b76e702d053aaca648b977ec3bb663 (patch) | |
| tree | 7f7d36eabd41737fce559d25adf7a17046c9f007 /fxjs/fxjs_v8.cpp | |
| parent | 80435cb746fa7bd22cf062ab39829ec86000fd21 (diff) | |
| download | pdfium-5daf07afe5b76e702d053aaca648b977ec3bb663.tar.xz | |
Make NewNull return an actual Null
This CL updates the CFXJS_Engine::NewNull method to return a real v8::Null
instead of an empty v8::Local. This also adds a NewUndefined and returns
undefined in most of the places null was returned previously.
Change-Id: If1a96bf253057892a3b709cbc72f8825c52503c3
Reviewed-on: https://pdfium-review.googlesource.com/16730
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs/fxjs_v8.cpp')
| -rw-r--r-- | fxjs/fxjs_v8.cpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/fxjs/fxjs_v8.cpp b/fxjs/fxjs_v8.cpp index 4c6398870d..441848205f 100644 --- a/fxjs/fxjs_v8.cpp +++ b/fxjs/fxjs_v8.cpp @@ -664,7 +664,11 @@ v8::Local<v8::String> CFXJS_Engine::NewString(const WideStringView& str) { } v8::Local<v8::Value> CFXJS_Engine::NewNull() { - return v8::Local<v8::Value>(); + return v8::Null(m_isolate); +} + +v8::Local<v8::Value> CFXJS_Engine::NewUndefined() { + return v8::Undefined(m_isolate); } v8::Local<v8::Date> CFXJS_Engine::NewDate(double d) { |