Replace some repeated code with existing CFXJS_Engine::NewString() helper.

In turn, fix type information for New*() return values.
In turn, resolve some ambiguity in a ? operator expression.

Change-Id: I45c31d81f815b11590b46dacc8060d8e489dde5c
Reviewed-on: https://pdfium-review.googlesource.com/6131
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>

1 files changed, 6 insertions, 6 deletions

diff --git a/fxjs/fxjs_v8.h b/fxjs/fxjs_v8.h
index d44af2f8fa..cdec942d4b 100644
--- a/fxjs/fxjs_v8.h
+++ b/fxjs/fxjs_v8.h
@@ -182,12 +182,12 @@ class CFXJS_Engine {
 
   v8::Local<v8::Value> NewNull();
   v8::Local<v8::Array> NewArray();
-  v8::Local<v8::Value> NewNumber(int number);
-  v8::Local<v8::Value> NewNumber(double number);
-  v8::Local<v8::Value> NewNumber(float number);
-  v8::Local<v8::Value> NewBoolean(bool b);
-  v8::Local<v8::Value> NewString(const CFX_ByteStringC& str);
-  v8::Local<v8::Value> NewString(const CFX_WideStringC& str);
+  v8::Local<v8::Number> NewNumber(int number);
+  v8::Local<v8::Number> NewNumber(double number);
+  v8::Local<v8::Number> NewNumber(float number);
+  v8::Local<v8::Boolean> NewBoolean(bool b);
+  v8::Local<v8::String> NewString(const CFX_ByteStringC& str);
+  v8::Local<v8::String> NewString(const CFX_WideStringC& str);
   v8::Local<v8::Date> NewDate(double d);
   v8::Local<v8::Object> NewFxDynamicObj(int nObjDefnID, bool bStatic = false);