summaryrefslogtreecommitdiff
path: root/fxjs/fxjs_v8_embeddertest.cpp
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-02-07 21:07:24 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-02-07 21:07:24 +0000
commit9ad9a5fc81a36ab406ff49408dd0814d350bbc7e (patch)
treeec46a8cbec08c17d5932bd330c4fd4b5baa2c180 /fxjs/fxjs_v8_embeddertest.cpp
parent161f992a81e400eeebba49387f174d836750d624 (diff)
downloadpdfium-9ad9a5fc81a36ab406ff49408dd0814d350bbc7e.tar.xz
Split creation of ordinary object and bound objects in FXJS.chromium/3343
One can be performed by the CJS_V8 layer, the other requires the full FXJS mechanism. Avoids using -1 as a special case. Change-Id: I4a14ccb6a7fea393f84b70a07ada03b1a83c7d36 Reviewed-on: https://pdfium-review.googlesource.com/25830 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/fxjs_v8_embeddertest.cpp')
-rw-r--r--fxjs/fxjs_v8_embeddertest.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/fxjs/fxjs_v8_embeddertest.cpp b/fxjs/fxjs_v8_embeddertest.cpp
index 9e90663aa2..acc4366631 100644
--- a/fxjs/fxjs_v8_embeddertest.cpp
+++ b/fxjs/fxjs_v8_embeddertest.cpp
@@ -226,7 +226,7 @@ TEST_F(FXJSV8EmbedderTest, NewObject) {
v8::HandleScope handle_scope(isolate());
v8::Context::Scope context_scope(GetV8Context());
- auto object = engine()->NewFxDynamicObj(-1);
+ auto object = engine()->NewObject();
ASSERT_FALSE(object.IsEmpty());
EXPECT_EQ(0u, engine()->GetObjectPropertyNames(object).size());
EXPECT_FALSE(engine()->GetObjectProperty(object, L"clams").IsEmpty());