diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-08-17 16:44:50 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-08-17 16:44:50 +0000 |
| commit | 20736f7f5884cf1e2827543c92b6e47f8282aeaf (patch) | |
| tree | 9a0f3cbd9262d1676f70ab02c3fa5b4e0acaa03a /fxjs/xfa/cjx_desc.cpp | |
| parent | 21068062a038db72b5ee40512fe638acbdd17c3d (diff) | |
| download | pdfium-20736f7f5884cf1e2827543c92b6e47f8282aeaf.tar.xz | |
Introduce safer CJS_Return::Success() and Failure().
Avoid the possibility of ever re-introducing the issue noticed
last week.
Remove some redundant JSGetStringFromID() calls.
Change-Id: I56687c2191bd72e378f747083f34080e50cbe490
Reviewed-on: https://pdfium-review.googlesource.com/40490
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/xfa/cjx_desc.cpp')
| -rw-r--r-- | fxjs/xfa/cjx_desc.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fxjs/xfa/cjx_desc.cpp b/fxjs/xfa/cjx_desc.cpp index aa8ee2961b..03379cedbc 100644 --- a/fxjs/xfa/cjx_desc.cpp +++ b/fxjs/xfa/cjx_desc.cpp @@ -23,8 +23,9 @@ CJX_Desc::~CJX_Desc() {} CJS_Return CJX_Desc::metadata(CFX_V8* runtime, const std::vector<v8::Local<v8::Value>>& params) { if (params.size() != 0 && params.size() != 1) - return CJS_Return(JSGetStringFromID(JSMessage::kParamError)); - return CJS_Return(runtime->NewString("")); + return CJS_Return::Failure(JSMessage::kParamError); + + return CJS_Return::Success(runtime->NewString("")); } void CJX_Desc::use(CFXJSE_Value* pValue, |