diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2018-02-13 21:09:32 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-13 21:09:32 +0000 |
| commit | 20eb52e66c565d36a78dc1399f04f7485ccf8fe6 (patch) | |
| tree | 679fc502d00ce8807295053b2e5e5ac79e14d43d /fxjs/xfa/cjx_node.cpp | |
| parent | 80bf582f00adeefae67ae432b74c3b0609e7845e (diff) | |
| download | pdfium-20eb52e66c565d36a78dc1399f04f7485ccf8fe6.tar.xz | |
Cleanup CFX_XMLNode and friendschromium/3347
This CL removes unused methods from CFX_XMLNode, adds an AppendChild to
handle the case of a -1 index to InsertChildNode, removes the
InsertChildNode return value which is unused and cleans up various other
things.
Change-Id: I3a022e4dc2afffa6893ad11014034dd7ed301f13
Reviewed-on: https://pdfium-review.googlesource.com/26510
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/xfa/cjx_node.cpp')
| -rw-r--r-- | fxjs/xfa/cjx_node.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fxjs/xfa/cjx_node.cpp b/fxjs/xfa/cjx_node.cpp index b1749d6025..e5396b7c90 100644 --- a/fxjs/xfa/cjx_node.cpp +++ b/fxjs/xfa/cjx_node.cpp @@ -251,7 +251,7 @@ CJS_Return CJX_Node::loadXML(CFX_V8* runtime, CFX_XMLNode* pXMLSibling = pXMLChild->GetNodeItem(CFX_XMLNode::NextSibling); pXMLNode->RemoveChildNode(pXMLChild); - pFakeXMLRoot->InsertChildNode(pXMLChild); + pFakeXMLRoot->AppendChild(pXMLChild); pXMLChild = pXMLSibling; } } else { @@ -259,7 +259,7 @@ CJS_Return CJX_Node::loadXML(CFX_V8* runtime, if (pXMLParent) pXMLParent->RemoveChildNode(pXMLNode); - pFakeXMLRoot->InsertChildNode(pXMLNode); + pFakeXMLRoot->AppendChild(pXMLNode); } pParser->ConstructXFANode(pFakeRoot, pFakeXMLRoot.get()); |