diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-08-07 17:02:12 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-08-07 17:02:12 +0000 |
| commit | c0352f4584bf738b0073114d25e81e57b490d655 (patch) | |
| tree | 5c3f5a9e619f318dd5e4e34069d487b868d8992c /fxjs/xfa/cjx_object.cpp | |
| parent | f3a3393a2f96bb8c4cc275ee67921e2b7bddf540 (diff) | |
| download | pdfium-c0352f4584bf738b0073114d25e81e57b490d655.tar.xz | |
Speculative fix for null deref above ThrowNoDefaultPropertyException
Avoid possibility of an unterminated string or nullptr by avoiding
stringviews, since the non-view classes copy and always provide
a suitable result. Always use %ls and widestrings in wprintf()
variants, since that combination is consistent across our platforms
(%s, %S, etc. have idiosyncracies).
Bug: 870952
Change-Id: Ief62a42c3486e8298f9583b56e9333db1a74972a
Reviewed-on: https://pdfium-review.googlesource.com/39551
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'fxjs/xfa/cjx_object.cpp')
| -rw-r--r-- | fxjs/xfa/cjx_object.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fxjs/xfa/cjx_object.cpp b/fxjs/xfa/cjx_object.cpp index 6984c3a998..23e754d4b7 100644 --- a/fxjs/xfa/cjx_object.cpp +++ b/fxjs/xfa/cjx_object.cpp @@ -193,7 +193,7 @@ void CJX_Object::ThrowIndexOutOfBoundsException() const { void CJX_Object::ThrowParamCountMismatchException( const WideString& method) const { - ThrowException(L"Incorrect number of parameters calling method '%.16s'.", + ThrowException(L"Incorrect number of parameters calling method '%ls'.", method.c_str()); } |