diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2018-05-16 17:35:33 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-05-16 17:35:33 +0000 |
| commit | 7675a246431600fb26d430fcd29503d8b48fe8e1 (patch) | |
| tree | 62b70331a59d0f9f9f53b63b059bcd1462805899 /fxjs/xfa/cjx_object.h | |
| parent | 6facd15a7ecfbae24f2c356fa3b358288120a6f2 (diff) | |
| download | pdfium-7675a246431600fb26d430fcd29503d8b48fe8e1.tar.xz | |
Convert CJX_Object::Set* methods to return void
We never use the return values of these methods, switch to void from
bool.
Change-Id: I8b0d96e5be90ac08281bbb82d2c7205d94abea2b
Reviewed-on: https://pdfium-review.googlesource.com/32616
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs/xfa/cjx_object.h')
| -rw-r--r-- | fxjs/xfa/cjx_object.h | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/fxjs/xfa/cjx_object.h b/fxjs/xfa/cjx_object.h index 88f1d8c814..1fcd753b14 100644 --- a/fxjs/xfa/cjx_object.h +++ b/fxjs/xfa/cjx_object.h @@ -74,10 +74,10 @@ class CJX_Object { const std::vector<v8::Local<v8::Value>>& params); bool HasAttribute(XFA_Attribute eAttr); - bool SetAttribute(XFA_Attribute eAttr, + void SetAttribute(XFA_Attribute eAttr, const WideStringView& wsValue, bool bNotify); - bool SetAttribute(const WideStringView& wsAttr, + void SetAttribute(const WideStringView& wsAttr, const WideStringView& wsValue, bool bNotify); void RemoveAttribute(const WideStringView& wsAttr); @@ -88,7 +88,7 @@ class CJX_Object { Optional<WideString> TryAttribute(XFA_Attribute eAttr, bool bUseDefault); Optional<WideString> TryContent(bool bScriptModify, bool bProto); - bool SetContent(const WideString& wsContent, + void SetContent(const WideString& wsContent, const WideString& wsXMLValue, bool bNotify, bool bScriptModify, @@ -177,11 +177,11 @@ class CJX_Object { Optional<WideString> TryNamespace(); Optional<int32_t> TryInteger(XFA_Attribute eAttr, bool bUseDefault); - bool SetInteger(XFA_Attribute eAttr, int32_t iValue, bool bNotify); + void SetInteger(XFA_Attribute eAttr, int32_t iValue, bool bNotify); int32_t GetInteger(XFA_Attribute eAttr); Optional<WideString> TryCData(XFA_Attribute eAttr, bool bUseDefault); - bool SetCData(XFA_Attribute eAttr, + void SetCData(XFA_Attribute eAttr, const WideString& wsValue, bool bNotify, bool bScriptModify); @@ -189,17 +189,17 @@ class CJX_Object { Optional<XFA_AttributeEnum> TryEnum(XFA_Attribute eAttr, bool bUseDefault) const; - bool SetEnum(XFA_Attribute eAttr, XFA_AttributeEnum eValue, bool bNotify); + void SetEnum(XFA_Attribute eAttr, XFA_AttributeEnum eValue, bool bNotify); XFA_AttributeEnum GetEnum(XFA_Attribute eAttr) const; Optional<bool> TryBoolean(XFA_Attribute eAttr, bool bUseDefault); - bool SetBoolean(XFA_Attribute eAttr, bool bValue, bool bNotify); + void SetBoolean(XFA_Attribute eAttr, bool bValue, bool bNotify); bool GetBoolean(XFA_Attribute eAttr); Optional<CXFA_Measurement> TryMeasure(XFA_Attribute eAttr, bool bUseDefault) const; Optional<float> TryMeasureAsFloat(XFA_Attribute attr) const; - bool SetMeasure(XFA_Attribute eAttr, CXFA_Measurement mValue, bool bNotify); + void SetMeasure(XFA_Attribute eAttr, CXFA_Measurement mValue, bool bNotify); CXFA_Measurement GetMeasure(XFA_Attribute eAttr) const; void MergeAllData(CXFA_Object* pDstModule); @@ -241,7 +241,7 @@ class CJX_Object { void OnChanged(XFA_Attribute eAttr, bool bNotify, bool bScriptModify); void OnChanging(XFA_Attribute eAttr, bool bNotify); - bool SetUserData(void* pKey, + void SetUserData(void* pKey, void* pData, const XFA_MAPDATABLOCKCALLBACKINFO* pCallbackInfo); |