diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-06-19 17:33:32 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-06-19 17:33:32 +0000 |
| commit | e005dc33c31a2e701e1af3a0a3e5775cabbf1ddd (patch) | |
| tree | 6cf7623219078464910ee438311e24121c8af2a0 /fxjs/xfa | |
| parent | ed1c58049f0c164969946b6ad0ff06d952ab1949 (diff) | |
| download | pdfium-e005dc33c31a2e701e1af3a0a3e5775cabbf1ddd.tar.xz | |
Move fxcrt::{Byte,Wide}Strings with std::move().chromium/3466
Remove some string copies in barcode that were noticed whilst
looking for moves.
Change-Id: Ieda34d00f633576ba1f0dca283dcdabfb36f236c
Reviewed-on: https://pdfium-review.googlesource.com/35410
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/xfa')
| -rw-r--r-- | fxjs/xfa/cjx_layoutpseudomodel.cpp | 4 | ||||
| -rw-r--r-- | fxjs/xfa/cjx_object.cpp | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/fxjs/xfa/cjx_layoutpseudomodel.cpp b/fxjs/xfa/cjx_layoutpseudomodel.cpp index a5dcf98b00..e448aea252 100644 --- a/fxjs/xfa/cjx_layoutpseudomodel.cpp +++ b/fxjs/xfa/cjx_layoutpseudomodel.cpp @@ -7,6 +7,7 @@ #include "fxjs/xfa/cjx_layoutpseudomodel.h" #include <set> +#include <utility> #include "core/fxcrt/fx_coordinates.h" #include "fxjs/cfxjse_engine.h" @@ -84,10 +85,9 @@ CJS_Return CJX_LayoutPseudoModel::HWXY( if (params.size() >= 2) { WideString tmp_unit = runtime->ToWideString(params[1]); if (!tmp_unit.IsEmpty()) - unit = tmp_unit; + unit = std::move(tmp_unit); } int32_t iIndex = params.size() >= 3 ? runtime->ToInt32(params[2]) : 0; - CXFA_LayoutProcessor* pDocLayout = GetDocument()->GetLayoutProcessor(); if (!pDocLayout) return CJS_Return(); diff --git a/fxjs/xfa/cjx_object.cpp b/fxjs/xfa/cjx_object.cpp index a6b1d122ae..2cf6f6755d 100644 --- a/fxjs/xfa/cjx_object.cpp +++ b/fxjs/xfa/cjx_object.cpp @@ -1175,9 +1175,9 @@ void CJX_Object::Script_Attribute_String(CFXJSE_Value* pValue, WideString wsSOM; if (!wsValue.IsEmpty()) { if (wsValue[0] == '#') - wsID = WideString(wsValue.c_str() + 1, wsValue.GetLength() - 1); + wsID = wsValue.Mid(1, wsValue.GetLength() - 1); else - wsSOM = wsValue; + wsSOM = std::move(wsValue); } CXFA_Node* pProtoNode = nullptr; |