summaryrefslogtreecommitdiff
path: root/fxjs
diff options
context:
space:
mode:
authorDan Sinclair <dsinclair@chromium.org>2018-01-10 17:03:35 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-01-10 17:03:35 +0000
commit54f86140d436ce2f457dc588f5b2c183d4e94452 (patch)
treefcdbc16dc792cdcfba7b28f607cec84a742d8e93 /fxjs
parenta408ac86ecad7086b3af6aa04d994cc4da16f52d (diff)
downloadpdfium-54f86140d436ce2f457dc588f5b2c183d4e94452.tar.xz
Verify GetOrCreate results are checked
This CL updates users of the GetOrCreate* methods to verify that the value returned is not null before accessing. Change-Id: I4a9fd29a26d5e4ec792ca3671c9868828e53d46e Reviewed-on: https://pdfium-review.googlesource.com/22652 Reviewed-by: Ryan Harrison <rharrison@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs')
-rw-r--r--fxjs/xfa/cjx_node.cpp3
1 files changed, 3 insertions, 0 deletions
diff --git a/fxjs/xfa/cjx_node.cpp b/fxjs/xfa/cjx_node.cpp
index e8fa44eb17..cf2642c8ad 100644
--- a/fxjs/xfa/cjx_node.cpp
+++ b/fxjs/xfa/cjx_node.cpp
@@ -165,6 +165,9 @@ CJS_Return CJX_Node::getElement(
CXFA_Node* pNode = GetOrCreateProperty<CXFA_Node>(
iValue, CXFA_Node::NameToElement(expression));
+ if (!pNode)
+ return CJS_Return(runtime->NewNull());
+
CFXJSE_Value* value =
GetDocument()->GetScriptContext()->GetJSValueFromMap(pNode);
if (!value)