diff options
| author | dan sinclair <dsinclair@chromium.org> | 2017-10-24 21:40:24 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-10-25 18:14:09 +0000 |
| commit | 80435cb746fa7bd22cf062ab39829ec86000fd21 (patch) | |
| tree | 9085fa57d5f49eac4b56b065ca572f424c9f744b /fxjs | |
| parent | e85107bc8ab5bbd5b2d3f97fd6071d7ce4a78bcc (diff) | |
| download | pdfium-80435cb746fa7bd22cf062ab39829ec86000fd21.tar.xz | |
Convert JS input params to v8::Local<v8::Value>>s
This CL converts the JS set_* methods and the JSMethod methods to accept
v8::Local<v8::Value> objects instead of CJS_Value objects.
Change-Id: I6de41305deff458eba515bdc3462522b502f74ad
Reviewed-on: https://pdfium-review.googlesource.com/16670
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs')
| -rw-r--r-- | fxjs/cfxjse_context.cpp | 7 | ||||
| -rw-r--r-- | fxjs/cfxjse_context.h | 7 | ||||
| -rw-r--r-- | fxjs/fxjs_v8.h | 6 |
3 files changed, 8 insertions, 12 deletions
diff --git a/fxjs/cfxjse_context.cpp b/fxjs/cfxjse_context.cpp index ad6dbac0ad..0af2d361dd 100644 --- a/fxjs/cfxjse_context.cpp +++ b/fxjs/cfxjse_context.cpp @@ -74,7 +74,7 @@ class CFXJSE_ScopeUtil_IsolateHandleContext { }; v8::Local<v8::Object> FXJSE_GetGlobalObjectFromContext( - const v8::Local<v8::Context>& hContext) { + v8::Local<v8::Context> hContext) { return hContext->Global()->GetPrototype().As<v8::Object>(); } @@ -86,9 +86,8 @@ void FXJSE_UpdateObjectBinding(v8::Local<v8::Object>& hObject, hObject->SetAlignedPointerInInternalField(1, lpNewBinding); } -CFXJSE_HostObject* FXJSE_RetrieveObjectBinding( - const v8::Local<v8::Object>& hJSObject, - CFXJSE_Class* lpClass) { +CFXJSE_HostObject* FXJSE_RetrieveObjectBinding(v8::Local<v8::Object> hJSObject, + CFXJSE_Class* lpClass) { ASSERT(!hJSObject.IsEmpty()); if (!hJSObject->IsObject()) return nullptr; diff --git a/fxjs/cfxjse_context.h b/fxjs/cfxjse_context.h index 8ed876097e..f93469bc4d 100644 --- a/fxjs/cfxjse_context.h +++ b/fxjs/cfxjse_context.h @@ -53,13 +53,12 @@ v8::Local<v8::Object> FXJSE_CreateReturnValue(v8::Isolate* pIsolate, v8::TryCatch& trycatch); v8::Local<v8::Object> FXJSE_GetGlobalObjectFromContext( - const v8::Local<v8::Context>& hContext); + v8::Local<v8::Context> hContext); void FXJSE_UpdateObjectBinding(v8::Local<v8::Object>& hObject, CFXJSE_HostObject* lpNewBinding = nullptr); -CFXJSE_HostObject* FXJSE_RetrieveObjectBinding( - const v8::Local<v8::Object>& hJSObject, - CFXJSE_Class* lpClass = nullptr); +CFXJSE_HostObject* FXJSE_RetrieveObjectBinding(v8::Local<v8::Object> hJSObject, + CFXJSE_Class* lpClass = nullptr); #endif // FXJS_CFXJSE_CONTEXT_H_ diff --git a/fxjs/fxjs_v8.h b/fxjs/fxjs_v8.h index 457843f387..f5e52411f3 100644 --- a/fxjs/fxjs_v8.h +++ b/fxjs/fxjs_v8.h @@ -54,10 +54,8 @@ class V8TemplateMapTraits : public v8::StdMapTraits<void*, v8::Object> { typedef v8::GlobalValueMap<void*, v8::Object, V8TemplateMapTraits> MapType; typedef void WeakCallbackDataType; - static WeakCallbackDataType* WeakCallbackParameter( - MapType* map, - void* key, - const v8::Local<v8::Object>& value) { + static WeakCallbackDataType* + WeakCallbackParameter(MapType* map, void* key, v8::Local<v8::Object> value) { return key; } static MapType* MapFromWeakCallbackInfo( |