diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-11-22 22:04:12 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-11-22 22:04:12 +0000 |
| commit | 9d0d36b7f3e2106bbeb332edf821fc2c637e6ea0 (patch) | |
| tree | 6d1a17b202cdb73956e768c56c1316c0d163effb /fxjs | |
| parent | a1c4205eff6c8a0bb6a6abf58bbec06cb0fe22c5 (diff) | |
| download | pdfium-9d0d36b7f3e2106bbeb332edf821fc2c637e6ea0.tar.xz | |
Cleanup CXFA_ValidateData
This CL removes out-params in favour of returns; Makes params const;
Cleans up return types.
Change-Id: I2b7c237130a99859b08af0486a95b4c6f6974f62
Reviewed-on: https://pdfium-review.googlesource.com/19130
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs')
| -rw-r--r-- | fxjs/cjx_node.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/fxjs/cjx_node.cpp b/fxjs/cjx_node.cpp index 9da9cf0ce1..3d8a6ecdc7 100644 --- a/fxjs/cjx_node.cpp +++ b/fxjs/cjx_node.cpp @@ -1385,13 +1385,13 @@ void CJX_Node::Script_Som_Message(CFXJSE_Value* pValue, WideString wsMessage; switch (iMessageType) { case XFA_SOM_ValidationMessage: - validateData.GetScriptMessageText(wsMessage); + wsMessage = validateData.GetScriptMessageText(); break; case XFA_SOM_FormatMessage: - validateData.GetFormatMessageText(wsMessage); + wsMessage = validateData.GetFormatMessageText(); break; case XFA_SOM_MandatoryMessage: - validateData.GetNullMessageText(wsMessage); + wsMessage = validateData.GetNullMessageText(); break; default: break; @@ -1805,8 +1805,8 @@ void CJX_Node::Script_Som_Mandatory(CFXJSE_Value* pValue, return; } - const XFA_ATTRIBUTEENUMINFO* pInfo = GetAttributeEnumByID( - static_cast<XFA_ATTRIBUTEENUM>(validateData.GetNullTest())); + const XFA_ATTRIBUTEENUMINFO* pInfo = + GetAttributeEnumByID(validateData.GetNullTest()); if (!pInfo) { pValue->SetString(""); return; |