diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-06-21 15:02:24 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-06-21 15:02:24 +0000 |
| commit | 9c292fef316739f43730f11b9a2b6d3e4b725b54 (patch) | |
| tree | e286b6c7a36c50eba235c7b69b30b95fc36cb906 /fxjs | |
| parent | bcd66f54de1291ddf8b7b7caca3e7360e14fcc8d (diff) | |
| download | pdfium-9c292fef316739f43730f11b9a2b6d3e4b725b54.tar.xz | |
Avoid const-refs to implicitly constructed strings.
Because the invisible temporary goes out of scope at the next
semicolon.
Also avoid returning const string references since the cost is
low to properly keep the string alive.
Change-Id: Id283e4fd99f79a02d79d739a533a4ce05e831e2a
Reviewed-on: https://pdfium-review.googlesource.com/35710
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs')
| -rw-r--r-- | fxjs/cjs_eventhandler.cpp | 4 | ||||
| -rw-r--r-- | fxjs/cjs_eventhandler.h | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/fxjs/cjs_eventhandler.cpp b/fxjs/cjs_eventhandler.cpp index 0fd330fd13..43605d985b 100644 --- a/fxjs/cjs_eventhandler.cpp +++ b/fxjs/cjs_eventhandler.cpp @@ -396,7 +396,7 @@ WideString& CJS_EventHandler::Change() { return m_WideStrChangeDu; } -const WideString& CJS_EventHandler::ChangeEx() { +WideString CJS_EventHandler::ChangeEx() const { return m_WideStrChangeEx; } @@ -628,6 +628,6 @@ bool CJS_EventHandler::WillCommit() const { return m_bWillCommit; } -const WideString& CJS_EventHandler::TargetName() const { +WideString CJS_EventHandler::TargetName() const { return m_strTargetName; } diff --git a/fxjs/cjs_eventhandler.h b/fxjs/cjs_eventhandler.h index aa02895924..7c33ed739e 100644 --- a/fxjs/cjs_eventhandler.h +++ b/fxjs/cjs_eventhandler.h @@ -144,7 +144,7 @@ class CJS_EventHandler { bool IsValid() const; WideString& Change(); - const WideString& ChangeEx(); + WideString ChangeEx() const; int CommitKey() const; bool FieldFull() const; bool KeyDown() const; @@ -161,7 +161,7 @@ class CJS_EventHandler { CJS_Field* Target_Field(); WideString& Value(); bool WillCommit() const; - const WideString& TargetName() const; + WideString TargetName() const; JS_EVENT_T EventType() const { return m_eEventType; } |