summaryrefslogtreecommitdiff
path: root/fxjs
diff options
context:
space:
mode:
authorDan Sinclair <dsinclair@chromium.org>2017-11-20 20:35:48 +0000
committerChromium commit bot <commit-bot@chromium.org>2017-11-20 20:35:48 +0000
commit1b36b90f2e33f5a80e6ae9b22821a623a9d62782 (patch)
tree60c79894c81732faa6a5fba7f7fd56ff8b602ecc /fxjs
parent71803d230109cb841a323c579082a5cbd6fcbe3c (diff)
downloadpdfium-1b36b90f2e33f5a80e6ae9b22821a623a9d62782.tar.xz
Convert picture methods to return the string
This CL converts CXFA_BindData::GetPicture and CXFA_WidgetData::GetPictureContent to return the WideString instead of taking an out param. The original bool result was never checked. Change-Id: I4503d53ac7276edea811a28c34c7d8cc4cb50572 Reviewed-on: https://pdfium-review.googlesource.com/18810 Reviewed-by: Ryan Harrison <rharrison@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs')
-rw-r--r--fxjs/cjx_node.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/fxjs/cjx_node.cpp b/fxjs/cjx_node.cpp
index bf8c1f726e..8f99b1a5b8 100644
--- a/fxjs/cjx_node.cpp
+++ b/fxjs/cjx_node.cpp
@@ -1452,8 +1452,8 @@ void CJX_Node::Script_Som_DefaultValue(CFXJSE_Value* pValue,
pContainerWidgetData = pFormNode->GetContainerWidgetData();
if (pContainerWidgetData) {
- pContainerWidgetData->GetPictureContent(wsPicture,
- XFA_VALUEPICTURE_DataBind);
+ wsPicture = pContainerWidgetData->GetPictureContent(
+ XFA_VALUEPICTURE_DataBind);
}
if (!wsPicture.IsEmpty())
break;