summaryrefslogtreecommitdiff
path: root/fxjs
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-06-22 17:46:05 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-06-22 17:46:05 +0000
commit9fff1c76c1083a5cc0543911811e36007a38aa3a (patch)
treed7769c918bdf41a572d3869c5f2e3982636b50a0 /fxjs
parente6ca7c2d7d45bd59d53c3c6f9952e2001cf81890 (diff)
downloadpdfium-9fff1c76c1083a5cc0543911811e36007a38aa3a.tar.xz
Avoid some duplicate const/non-const getters.
Getters should nearly always be const when they return a non-const pointer to an unowned object. Saves a bit of code along the way. Grep for similar occurrences and add "const". Change-Id: I492bf962a7d62452fa40310146226dc0c8ebb753 Reviewed-on: https://pdfium-review.googlesource.com/35890 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'fxjs')
-rw-r--r--fxjs/cfxjse_engine.h2
-rw-r--r--fxjs/xfa/cjx_object.h4
2 files changed, 2 insertions, 4 deletions
diff --git a/fxjs/cfxjse_engine.h b/fxjs/cfxjse_engine.h
index 62de0614c4..0ae16df84e 100644
--- a/fxjs/cfxjse_engine.h
+++ b/fxjs/cfxjse_engine.h
@@ -56,7 +56,7 @@ class CFXJSE_Engine : public CFX_V8 {
~CFXJSE_Engine() override;
void SetEventParam(CXFA_EventParam* param) { m_eventParam = param; }
- CXFA_EventParam* GetEventParam() { return m_eventParam.Get(); }
+ CXFA_EventParam* GetEventParam() const { return m_eventParam.Get(); }
bool RunScript(CXFA_Script::Type eScriptType,
const WideStringView& wsScript,
CFXJSE_Value* pRetValue,
diff --git a/fxjs/xfa/cjx_object.h b/fxjs/xfa/cjx_object.h
index 44df6c4c5a..0ee2b66199 100644
--- a/fxjs/xfa/cjx_object.h
+++ b/fxjs/xfa/cjx_object.h
@@ -60,10 +60,8 @@ class CJX_Object {
JS_PROP(className);
- CXFA_Object* GetXFAObject() { return object_.Get(); }
- const CXFA_Object* GetXFAObject() const { return object_.Get(); }
-
CXFA_Document* GetDocument() const;
+ CXFA_Object* GetXFAObject() const { return object_.Get(); }
void SetCalcRecursionCount(size_t count) { calc_recursion_count_ = count; }
size_t GetCalcRecursionCount() const { return calc_recursion_count_; }