diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-11-02 18:15:07 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-11-02 18:15:07 +0000 |
| commit | 77fe069bd19ea8207664293f631c63dab330f825 (patch) | |
| tree | 25ecc84aefed75c57c7783e464392591d71cc692 /fxjs | |
| parent | f45406f8ec992560353756cff1e2c3931984e62b (diff) | |
| download | pdfium-77fe069bd19ea8207664293f631c63dab330f825.tar.xz | |
Remove default value to CJX_Node::SetAttribute
The bNotify value has been moved into the call sites and the default
removed.
Change-Id: Ifd2c0252b0f1421f7fc244d69e6f6bddc80e5591
Reviewed-on: https://pdfium-review.googlesource.com/17450
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs')
| -rw-r--r-- | fxjs/cjx_node.cpp | 8 | ||||
| -rw-r--r-- | fxjs/cjx_node.h | 5 |
2 files changed, 7 insertions, 6 deletions
diff --git a/fxjs/cjx_node.cpp b/fxjs/cjx_node.cpp index 64894b7c7e..3fd08772e2 100644 --- a/fxjs/cjx_node.cpp +++ b/fxjs/cjx_node.cpp @@ -2732,7 +2732,8 @@ void CJX_Node::Script_Form_Checksum(CFXJSE_Value* pValue, bool bSetting, XFA_ATTRIBUTE eAttribute) { if (bSetting) { - SetAttribute(XFA_ATTRIBUTE_Checksum, pValue->ToWideString().AsStringView()); + SetAttribute(XFA_ATTRIBUTE_Checksum, pValue->ToWideString().AsStringView(), + false); return; } WideString wsChecksum; @@ -3440,7 +3441,8 @@ bool CJX_Node::SetScriptContent(const WideString& wsContent, GetAttribute(XFA_ATTRIBUTE_ContentType, wsContentType, false); if (wsContentType == L"text/html") { wsContentType = L""; - SetAttribute(XFA_ATTRIBUTE_ContentType, wsContentType.AsStringView()); + SetAttribute(XFA_ATTRIBUTE_ContentType, wsContentType.AsStringView(), + false); } } CXFA_Node* pContentRawDataNode = @@ -3531,7 +3533,7 @@ bool CJX_Node::TryContent(WideString& wsContent, CXFA_Node* pChildValue = pValue->GetNodeItem(XFA_NODEITEM_FirstChild); if (pChildValue && XFA_FieldIsMultiListBox(GetXFANode())) { pChildValue->JSNode()->SetAttribute(XFA_ATTRIBUTE_ContentType, - L"text/xml"); + L"text/xml", false); } return pChildValue ? pChildValue->JSNode()->TryContent( wsContent, bScriptModify, bProto) diff --git a/fxjs/cjx_node.h b/fxjs/cjx_node.h index 77c564e11b..47fb0d62f0 100644 --- a/fxjs/cjx_node.h +++ b/fxjs/cjx_node.h @@ -55,11 +55,10 @@ class CJX_Node : public CJX_Object { bool HasAttribute(XFA_ATTRIBUTE eAttr); bool SetAttribute(XFA_ATTRIBUTE eAttr, const WideStringView& wsValue, - bool bNotify = false); - + bool bNotify); bool SetAttribute(const WideStringView& wsAttr, const WideStringView& wsValue, - bool bNotify = false); + bool bNotify); bool GetAttribute(const WideStringView& wsAttr, WideString& wsValue, bool bUseDefault = true); |