diff options
| author | weili <weili@chromium.org> | 2016-06-18 06:25:37 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-06-18 06:25:37 -0700 |
| commit | eec3a366adbfada36b98f1de651546ee09df8fc0 (patch) | |
| tree | 794aa8c69392b60d8737a8a5b424732b98bdd4b4 /fxjse/include | |
| parent | 4ce94e118d66064715de5baebeb4b2b580dcac66 (diff) | |
| download | pdfium-eec3a366adbfada36b98f1de651546ee09df8fc0.tar.xz | |
Make code compile with clang_use_chrome_plugin (final)
This change mainly contains files in xfa/ and fxjse/ directories
which were not covered by previous changes.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins. After this change, PDFium can be
compiled with "clang_use_chrome_plugin=true" for GN build. Since
clang_use_chrome_plugin is true by default, we no longer need to
set this parameter explicitly.
The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;
BUG=pdfium:469
Review-Url: https://codereview.chromium.org/2072803002
Diffstat (limited to 'fxjse/include')
| -rw-r--r-- | fxjse/include/cfxjse_class.h | 5 | ||||
| -rw-r--r-- | fxjse/include/cfxjse_value.h | 3 |
2 files changed, 5 insertions, 3 deletions
diff --git a/fxjse/include/cfxjse_class.h b/fxjse/include/cfxjse_class.h index bb1db6d48c..b4953d21d3 100644 --- a/fxjse/include/cfxjse_class.h +++ b/fxjse/include/cfxjse_class.h @@ -16,6 +16,8 @@ class CFXJSE_Value; class CFXJSE_Class { public: + ~CFXJSE_Class(); + static CFXJSE_Class* Create(CFXJSE_Context* pContext, const FXJSE_CLASS_DESCRIPTOR* lpClassDefintion, FX_BOOL bIsJSGlobal = FALSE); @@ -30,8 +32,7 @@ class CFXJSE_Class { v8::Global<v8::FunctionTemplate>& GetTemplate() { return m_hTemplate; } protected: - explicit CFXJSE_Class(CFXJSE_Context* lpContext) - : m_lpClassDefinition(nullptr), m_pContext(lpContext) {} + explicit CFXJSE_Class(CFXJSE_Context* lpContext); CFX_ByteString m_szClassName; const FXJSE_CLASS_DESCRIPTOR* m_lpClassDefinition; diff --git a/fxjse/include/cfxjse_value.h b/fxjse/include/cfxjse_value.h index 74b4bab2e2..6e14d48f8f 100644 --- a/fxjse/include/cfxjse_value.h +++ b/fxjse/include/cfxjse_value.h @@ -11,7 +11,8 @@ class CFXJSE_Value { public: - CFXJSE_Value(v8::Isolate* pIsolate) : m_pIsolate(pIsolate) {} + explicit CFXJSE_Value(v8::Isolate* pIsolate); + ~CFXJSE_Value(); FX_BOOL IsUndefined() const { if (m_hValue.IsEmpty()) { |