summaryrefslogtreecommitdiff
path: root/pdfium.gyp
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2015-02-27 13:48:38 -0800
committerTom Sepez <tsepez@chromium.org>2015-02-27 13:48:38 -0800
commit5b47dbfe85e8db4122089afa6d00264f1e973af2 (patch)
tree2414ade38cf9e0040a63e77dc4da9598b8139d9d /pdfium.gyp
parent3d25502adc5ae37d1c3c74d367f16f770c465109 (diff)
downloadpdfium-5b47dbfe85e8db4122089afa6d00264f1e973af2.tar.xz
Remove unused IDS_ constants from pdfium.
Along the way, I noticed that one of these is used in a header file that isn't included anywhere and describes no actual code (JS_Console.h). Also add missing header guards, and IWYU to resources.h Also move a static function from a header to the new resources.cpp file. Also fix the grammar on some of the error messages. Most of these appear to be JS error messages destined for a JS error handler or (someday) a console (which can remain in english), and oddly, some appear to be about failed form validation, which smells user-facing. Also check that the message makes sense for the point the C++ code wants to use it, and reword accordingly. As it turns out, these currently don't make it back to JS due to the unimplemented JS_Error() function; this is an enabling step towards implementing it. R=thestig@chromium.org Review URL: https://codereview.chromium.org/955273003
Diffstat (limited to 'pdfium.gyp')
-rw-r--r--pdfium.gyp2
1 files changed, 1 insertions, 1 deletions
diff --git a/pdfium.gyp b/pdfium.gyp
index 7b959bd45c..4134b49f8d 100644
--- a/pdfium.gyp
+++ b/pdfium.gyp
@@ -742,7 +742,6 @@
'fpdfsdk/include/javascript/Icon.h',
'fpdfsdk/include/javascript/IJavaScript.h',
'fpdfsdk/include/javascript/JavaScript.h',
- 'fpdfsdk/include/javascript/JS_Console.h',
'fpdfsdk/include/javascript/JS_Context.h',
'fpdfsdk/include/javascript/JS_Define.h',
'fpdfsdk/include/javascript/JS_EventHandler.h',
@@ -772,6 +771,7 @@
'fpdfsdk/src/javascript/JS_Value.cpp',
'fpdfsdk/src/javascript/PublicMethods.cpp',
'fpdfsdk/src/javascript/report.cpp',
+ 'fpdfsdk/src/javascript/resource.cpp',
'fpdfsdk/src/javascript/util.cpp',
],
},