summaryrefslogtreecommitdiff
path: root/pdfium.gyp
diff options
context:
space:
mode:
authorweili <weili@chromium.org>2016-05-16 17:52:17 -0700
committerCommit bot <commit-bot@chromium.org>2016-05-16 17:52:17 -0700
commit5f3b41bca725090391b9053a9435c86fa7b22df1 (patch)
tree2c2adf52a6cf127de85d1f1705b6c56b52b4fec2 /pdfium.gyp
parent3857904e520ecb06bad545e4e4bfcf4e60dd1f52 (diff)
downloadpdfium-5f3b41bca725090391b9053a9435c86fa7b22df1.tar.xz
Use chromium_code standard for PDFium GYP compilation
Define and use chromium_code to be used in standalone PDFium GYP build so that PDFium code can have more stringent warning level. This is also enabled on GN build by default so that GYP and GN builds can have consistent compilation results. Also enable chromium_code for PDFium compilation in Chromium since most of the warnings are cleared. The left ones are clearly marked and will be addressed soon. A few more clean-ups for the build: -- Remove the suppression of sign-compare warnings for Clang since the code is clean and the warning can be re-enabled. -- Re-enable "treat warning as errors" on Mac -- Add a flag to make GCC build works as well. BUG=pdfium:29, pdfium:475 Review-Url: https://codereview.chromium.org/1985843002
Diffstat (limited to 'pdfium.gyp')
-rw-r--r--pdfium.gyp11
1 files changed, 1 insertions, 10 deletions
diff --git a/pdfium.gyp b/pdfium.gyp
index 5532bc8360..310fec5bf4 100644
--- a/pdfium.gyp
+++ b/pdfium.gyp
@@ -4,8 +4,7 @@
{
'variables': {
- # TODO(thakis): Enable this, pdfium:29
- #'chromium_code': 1,
+ 'chromium_code': 1,
'variables': {
'clang_use_pdfium_plugins%': 0,
@@ -95,14 +94,6 @@
'msvs_disabled_warnings': [
4267,
],
- 'variables': {
- 'clang_warning_flags': [
- # TODO(thestig): Fix all instances, remove this, pdfium:29
- '-Wno-sign-compare',
- ],
- # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux.
- 'cflags_cc!': [ '-Wsign-compare' ],
- },
},
'targets': [
{