diff options
| author | dsinclair <dsinclair@chromium.org> | 2016-08-03 10:08:13 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-08-03 10:08:13 -0700 |
| commit | e85f971fe9ba628e46bcb0709d5da4368c15d0b0 (patch) | |
| tree | ef0bd0cecbd4b7be0fcd9031be002ffc10fd7fb7 /pdfium.gyp | |
| parent | 0d8c2d120efe62d79d083f25b43aa814d0f24646 (diff) | |
| download | pdfium-e85f971fe9ba628e46bcb0709d5da4368c15d0b0.tar.xz | |
Fix FMCallExpression undefined shift behaviour.
When determining which params should be an object and which are a value it is
possible to overflow the int on the shift comparision (if there are more then
32 arguments).
This never happens in practise as it's a controlled list of method calls which
we pass objects for. Cap the check at 32 for the shifting so it doesn't
overflow. We can revisit and extend the value later if we ever have an internal
formcalc method that needs an object in a position greater then 32.
BUG=chromium:603490
Review-Url: https://codereview.chromium.org/2206253002
Diffstat (limited to 'pdfium.gyp')
| -rw-r--r-- | pdfium.gyp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/pdfium.gyp b/pdfium.gyp index 61890e81cd..26f46edba9 100644 --- a/pdfium.gyp +++ b/pdfium.gyp @@ -949,6 +949,7 @@ 'xfa/fde/xml/fde_xml_imp_unittest.cpp', 'xfa/fxbarcode/pdf417/BC_PDF417HighLevelEncoder_unittest.cpp', 'xfa/fxfa/app/xfa_textlayout_unittest.cpp', + 'xfa/fxfa/fm2js/xfa_simpleexpression_unittest.cpp', 'xfa/fxfa/parser/xfa_utils_unittest.cpp', ], }], |