diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2018-05-02 16:17:32 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-05-02 16:17:32 +0000 |
| commit | 32ea6d0f847dab80e5fc03142ffa2238b552b357 (patch) | |
| tree | 9201110f619bfc0c7c323e4b3c626295f3338037 /public/PRESUBMIT.py | |
| parent | 70180648ffd01dd3716871758411d2031aaaebbe (diff) | |
| download | pdfium-32ea6d0f847dab80e5fc03142ffa2238b552b357.tar.xz | |
Cleanup XFA document properly on failed load
When we fail to parse an XFA document we would free the XML document
that is created immediately. This causes issues because the XML nodes
may have been set into the CXFA_Document already. This CL changes
ParseDoc to always save the XMLDocument and then triggers the CloseDoc()
logic if the ParseDoc method fails.
This should properly cleanup any resources on a failed document load.
Bug: chromium:837578
Change-Id: I8af7e6e34e3b756455c58ea50b22af414ffa6cbf
Reviewed-on: https://pdfium-review.googlesource.com/31710
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'public/PRESUBMIT.py')
0 files changed, 0 insertions, 0 deletions