Review and cleanup lint warnings.

This CL goes through the remaining list of list warnings and records why they
are currently blacklisted, or fixes and enables them.

R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1773733002 .

4 files changed, 38 insertions, 11 deletions

diff --git a/public/fpdf_dataavail.h b/public/fpdf_dataavail.h
index 0f8ff7d6d7..fc23337840 100644
--- a/public/fpdf_dataavail.h
+++ b/public/fpdf_dataavail.h
@@ -55,7 +55,9 @@ typedef struct _FX_FILEAVAIL {
    * Comments:
    *      Called by Foxit SDK to check whether the data section is ready.
    */
-  FPDF_BOOL (*IsDataAvail)(struct _FX_FILEAVAIL* pThis, size_t offset, size_t size);
+  FPDF_BOOL (*IsDataAvail)(struct _FX_FILEAVAIL* pThis,
+                           size_t offset,
+                           size_t size);
 } FX_FILEAVAIL;
 
 typedef void* FPDF_AVAIL;
diff --git a/public/fpdf_doc.h b/public/fpdf_doc.h
index de05eb3a59..eae7c95e49 100644
--- a/public/fpdf_doc.h
+++ b/public/fpdf_doc.h
@@ -272,7 +272,7 @@ DLLEXPORT FPDF_BOOL STDCALL FPDFLink_Enumerate(FPDF_PAGE page,
                                                FPDF_LINK* linkAnnot);
 
 // Function: FPDFLink_GetAnnotRect
-//          Get the annotation rectangle. (Specified by the ˇ°Rectˇ± entry of
+//          Get the annotation rectangle. (Specified by the |Rect| entry of
 //          annotation dictionary).
 // Parameters:
 //          linkAnnot[in]       -   Handle to the link annotation.
diff --git a/public/fpdf_formfill.h b/public/fpdf_formfill.h
index 31117538e2..3aeccb92f3 100644
--- a/public/fpdf_formfill.h
+++ b/public/fpdf_formfill.h
@@ -577,7 +577,9 @@ typedef struct _FPDF_FORMFILLINFO {
   *       To successfully run the javascript action, implementation need to load
   * the page for SDK.
   * */
-  FPDF_PAGE   (*FFI_GetPage)(struct _FPDF_FORMFILLINFO* pThis, FPDF_DOCUMENT document, int nPageIndex);
+  FPDF_PAGE (*FFI_GetPage)(struct _FPDF_FORMFILLINFO* pThis,
+                             FPDF_DOCUMENT document,
+                             int nPageIndex);
 
   /**
   * Method: FFI_GetCurrentPage
@@ -593,7 +595,8 @@ typedef struct _FPDF_FORMFILLINFO {
   * Return value:
   *       Handle to the page. Returned by FPDF_LoadPage function.
   * */
-  FPDF_PAGE   (*FFI_GetCurrentPage)(struct _FPDF_FORMFILLINFO* pThis, FPDF_DOCUMENT document);
+  FPDF_PAGE (*FFI_GetCurrentPage)(struct _FPDF_FORMFILLINFO* pThis,
+                                    FPDF_DOCUMENT document);
 
   /**
   * Method: FFI_GetRotation
@@ -857,7 +860,12 @@ typedef struct _FPDF_FORMFILLINFO {
   * Return value:
   *       TRUE indicates success; otherwise false.
   **/
-  FPDF_BOOL (*FFI_PopupMenu)(struct _FPDF_FORMFILLINFO* pThis, FPDF_PAGE page, FPDF_WIDGET hWidget, int menuFlag, float x, float y);
+  FPDF_BOOL (*FFI_PopupMenu)(struct _FPDF_FORMFILLINFO* pThis,
+                             FPDF_PAGE page,
+                             FPDF_WIDGET hWidget,
+                             int menuFlag,
+                             float x,
+                             float y);
 
   /**
   * Method: FFI_OpenFile
@@ -988,7 +996,8 @@ typedef struct _FPDF_FORMFILLINFO {
   * Return value:
   *       The handle to FPDF_FILEHANDLER.
   **/
-  FPDF_LPFILEHANDLER  (*FFI_DownloadFromURL)(struct _FPDF_FORMFILLINFO* pThis, FPDF_WIDESTRING URL);
+  FPDF_LPFILEHANDLER (*FFI_DownloadFromURL)(struct _FPDF_FORMFILLINFO* pThis,
+                                             FPDF_WIDESTRING URL);
   /**
   * Method: FFI_PostRequestURL
   *           This method will post the request to the server URL.
@@ -1010,7 +1019,13 @@ typedef struct _FPDF_FORMFILLINFO {
   * Return value:
   *       TRUE indicates success, otherwise FALSE.
   **/
-  FPDF_BOOL   (*FFI_PostRequestURL)(struct _FPDF_FORMFILLINFO* pThis, FPDF_WIDESTRING wsURL, FPDF_WIDESTRING wsData, FPDF_WIDESTRING wsContentType, FPDF_WIDESTRING wsEncode, FPDF_WIDESTRING wsHeader, FPDF_BSTR* respone);
+  FPDF_BOOL (*FFI_PostRequestURL)(struct _FPDF_FORMFILLINFO* pThis,
+                                    FPDF_WIDESTRING wsURL,
+                                    FPDF_WIDESTRING wsData,
+                                    FPDF_WIDESTRING wsContentType,
+                                    FPDF_WIDESTRING wsEncode,
+                                    FPDF_WIDESTRING wsHeader,
+                                    FPDF_BSTR* respone);
 
   /**
   * Method: FFI_PutRequestURL
@@ -1028,7 +1043,10 @@ typedef struct _FPDF_FORMFILLINFO {
   * Return value:
   *       TRUE indicates success, otherwise FALSE.
   **/
-  FPDF_BOOL   (*FFI_PutRequestURL)(struct _FPDF_FORMFILLINFO* pThis, FPDF_WIDESTRING wsURL, FPDF_WIDESTRING wsData, FPDF_WIDESTRING wsEncode);
+  FPDF_BOOL (*FFI_PutRequestURL)(struct _FPDF_FORMFILLINFO* pThis,
+                                   FPDF_WIDESTRING wsURL,
+                                   FPDF_WIDESTRING wsData,
+                                   FPDF_WIDESTRING wsEncode);
 #endif  // PDF_ENABLE_XFA
 } FPDF_FORMFILLINFO;
 
diff --git a/public/fpdfview.h b/public/fpdfview.h
index 2401affb17..68d0b1ad83 100644
--- a/public/fpdfview.h
+++ b/public/fpdfview.h
@@ -15,7 +15,8 @@
 #endif
 
 #ifdef PDF_ENABLE_XFA
-// TODO: remove the #define when XFA is officially in pdfium
+// PDF_USE_XFA is set in confirmation that this version of PDFium can support
+// XFA forms as requested by the PDF_ENABLE_XFA setting.
 #define PDF_USE_XFA
 #endif  // PDF_ENABLE_XFA
 
@@ -313,7 +314,10 @@ typedef struct _FPDF_FILEHANDLER {
    *
    * @return 0 for success, other value for failure.
    */
-  FPDF_RESULT (*ReadBlock)(FPDF_LPVOID clientData, FPDF_DWORD offset, FPDF_LPVOID buffer, FPDF_DWORD size);
+  FPDF_RESULT (*ReadBlock)(FPDF_LPVOID clientData,
+                           FPDF_DWORD offset,
+                           FPDF_LPVOID buffer,
+                           FPDF_DWORD size);
   /**
    * @brief   Callback function to write data into the current file stream.
    *
@@ -327,7 +331,10 @@ typedef struct _FPDF_FILEHANDLER {
    *
    * @return 0 for success, other value for failure.
    */
-  FPDF_RESULT (*WriteBlock)(FPDF_LPVOID clientData, FPDF_DWORD offset, FPDF_LPCVOID buffer, FPDF_DWORD size);
+  FPDF_RESULT (*WriteBlock)(FPDF_LPVOID clientData,
+                            FPDF_DWORD offset,
+                            FPDF_LPCVOID buffer,
+                            FPDF_DWORD size);
   /**
    * @brief   Callback function to flush all internal accessing buffers.
    *