diff options
| author | Nicolas Pena <npm@chromium.org> | 2017-09-13 18:02:11 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-09-13 22:12:47 +0000 |
| commit | 24b0733a72bbc4013bff8628f198b0aea807aa06 (patch) | |
| tree | ad2d50860409b5746ac467534ca433890999a821 /public | |
| parent | cb32712be1e545e3ceb4f41b77a8bebc2bf2726f (diff) | |
| download | pdfium-24b0733a72bbc4013bff8628f198b0aea807aa06.tar.xz | |
Change behaviour of FPDF_RenderPageBitmapWithMatrix
This CL changes the behavior of FPDF_RenderPageBitmapWithMatrix so it
transforms the bitmap. Before, the page would be transformed and the
assumption was that it would be drawn on a bitmap with the same
dimensions as the original page. This does not work well because a
transformation generally changes the dimensions of the page. The
rectangles test is modified to include small rectangles in the corner
of the page, so that it's clear that the whole original page is being
displayed.
Bug: pdfium:849
Change-Id: Ie89f959a1605fea59a15d239ca871ccd939ec92b
Reviewed-on: https://pdfium-review.googlesource.com/13510
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Diffstat (limited to 'public')
| -rw-r--r-- | public/fpdfview.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/public/fpdfview.h b/public/fpdfview.h index c74fcb99d0..135d00a8f4 100644 --- a/public/fpdfview.h +++ b/public/fpdfview.h @@ -666,7 +666,7 @@ FPDF_EXPORT void FPDF_CALLCONV FPDF_RenderPageBitmap(FPDF_BITMAP bitmap, // by FPDFBitmap_Create or retrieved by // FPDFImageObj_GetBitmap. // page - Handle to the page. Returned by FPDF_LoadPage -// matrix - The transform matrix. +// matrix - The transform matrix. It must be invertible. // clipping - The rect to clip to. // flags - 0 for normal display, or combination of the Page // Rendering flags defined above. With the FPDF_ANNOT @@ -674,7 +674,7 @@ FPDF_EXPORT void FPDF_CALLCONV FPDF_RenderPageBitmap(FPDF_BITMAP bitmap, // user-interaction, which are all annotations except // widget and popup annotations. // Return value: -// None. +// None. Note that behavior is undefined if det of |matrix| is 0. FPDF_EXPORT void FPDF_CALLCONV FPDF_RenderPageBitmapWithMatrix(FPDF_BITMAP bitmap, FPDF_PAGE page, |