diff options
| author | dsinclair <dsinclair@chromium.org> | 2016-10-20 10:58:52 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-10-20 10:58:52 -0700 |
| commit | 7403f8a2a0d87179a1ccd57ceccd2d84fa59c319 (patch) | |
| tree | c50f211d8efca99e9ec17733a776fca854c3f78c /samples/image_diff_png.cc | |
| parent | 05259e98f7416b59da18ee6059b48a23fddca8af (diff) | |
| download | pdfium-7403f8a2a0d87179a1ccd57ceccd2d84fa59c319.tar.xz | |
Revert of Traverse PDF page tree only once in CPDF_Document (patchset #4 id:60001 of https://codereview.chromium.org/2414423002/ )
Reason for revert:
Possible cause of crbug.com/657897 reverting to find out.
BUG=657897
Original issue's description:
> Traverse PDF page tree only once in CPDF_Document
>
> In our current implementation of CPDF_Document::GetPage, we traverse
> the PDF page tree until we find the index we are looking for. This is
> slow when we do calls GetPage(0), GetPage(1), ... since in this case
> the page tree will be traversed n times if there are n pages. This CL
> makes sure the page tree is only traversed once.
>
> Time to load the PDF from the bug below in chrome official build:
> Before this CL: 1 minute 40 seconds
> After this CL: 5 seconds
>
> BUG=chromium:638513
>
> Committed: https://pdfium.googlesource.com/pdfium/+/7c29e27dae139a205755c1a29b7f3ac8b36ec0da
TBR=thestig@chromium.org,tsepez@chromium.org,npm@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:638513
Review-Url: https://chromiumcodereview.appspot.com/2430313006
Diffstat (limited to 'samples/image_diff_png.cc')
0 files changed, 0 insertions, 0 deletions