diff options
| author | dan sinclair <dsinclair@chromium.org> | 2017-01-30 19:48:54 -0800 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-01-31 17:44:30 +0000 |
| commit | 00d4064e5414fc0845e354b50c7f1a8323449268 (patch) | |
| tree | cd1016cf5ce85dda2028f93531f298259b5e94a8 /samples | |
| parent | 576e8151efab01166142ec697b66ce38b7bf6780 (diff) | |
| download | pdfium-00d4064e5414fc0845e354b50c7f1a8323449268.tar.xz | |
Fixup test harness
When the results of the test runner were converted to return a tuple the
following code which checked the results for true/false were not updated
to extract the success value from the tuple. This caused the code to think
that the results always passed even when they failed.
This CL fixes the two tests which were broken (both just minor image result
differences) which slipped in during this breakage.
Change-Id: I01b56dd7b05013c2c12c83543746cf59b145e561
Reviewed-on: https://pdfium-review.googlesource.com/2456
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'samples')
| -rw-r--r-- | samples/BUILD.gn | 3 | ||||
| -rw-r--r-- | samples/pdfium_test.cc | 5 |
2 files changed, 8 insertions, 0 deletions
diff --git a/samples/BUILD.gn b/samples/BUILD.gn index 11bc9bab38..23f4d0ca56 100644 --- a/samples/BUILD.gn +++ b/samples/BUILD.gn @@ -30,6 +30,9 @@ config("pdfium_samples_config") { if (pdf_use_skia) { defines += [ "PDF_ENABLE_SKIA" ] } + if (is_asan) { + defines += [ "PDF_ENABLE_ASAN" ] + } if (use_coverage && is_clang) { cflags += [ "--coverage", diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc index 1e0a5be50e..a0afd4d09c 100644 --- a/samples/pdfium_test.cc +++ b/samples/pdfium_test.cc @@ -893,6 +893,11 @@ static void ShowConfig() { config.append("XFA"); maybe_comma = ","; #endif // PDF_ENABLE_XFA +#ifdef PDF_ENABLE_ASAN + config.append(maybe_comma); + config.append("ASAN"); + maybe_comma = ","; +#endif // PDF_ENABLE_ASAN printf("%s\n", config.c_str()); } |