Revert "Convert (void) to static_cast<void> in C++ code"

This reverts commit 80c6ab7b99bcbd7b940f78dc0cac52c30249f59c.

Reason for revert: (void) idiom is prevalent through out C++ code.

Original change's description:
> Convert (void) to static_cast<void> in C++ code
> 
> Converting instances of old C-style void casts to suppress return
> values to use C++ style static cases. There are a few examples of
> (void) that remain, since they are in C code, and the third_party/
> instances are not touched at all.
> 
> Change-Id: I72b3fc0e1d713db669b76135e03d1cf87873a2fe
> Reviewed-on: https://pdfium-review.googlesource.com/33790
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> Commit-Queue: Ryan Harrison <rharrison@chromium.org>

TBR=thestig@chromium.org,tsepez@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org,rharrison@chromium.org

Change-Id: Ib6cc021c97cb1ea7c71b90346fa9b500659f565d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://pdfium-review.googlesource.com/33890
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>

2 files changed, 6 insertions, 6 deletions

diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc
index 0491840b34..d2e84872d6 100644
--- a/samples/pdfium_test.cc
+++ b/samples/pdfium_test.cc
@@ -682,7 +682,7 @@ void RenderPdf(const std::string& name,
     return;
   }
 
-  static_cast<void>(FPDF_GetDocPermissions(doc.get()));
+  (void)FPDF_GetDocPermissions(doc.get());
 
   if (options.show_metadata)
     DumpMetaData(doc.get());
diff --git a/samples/pdfium_test_write_helper.cc b/samples/pdfium_test_write_helper.cc
index 758f5efe72..c436c97fbe 100644
--- a/samples/pdfium_test_write_helper.cc
+++ b/samples/pdfium_test_write_helper.cc
@@ -211,7 +211,7 @@ void WriteText(FPDF_PAGE page, const char* pdf_name, int num) {
   uint32_t bom = 0x0000FEFF;
   if (fwrite(&bom, sizeof(bom), 1, fp) != 1) {
     fprintf(stderr, "Failed to write to %s\n", filename);
-    static_cast<void>(fclose(fp));
+    (void)fclose(fp);
     return;
   }
 
@@ -223,7 +223,7 @@ void WriteText(FPDF_PAGE page, const char* pdf_name, int num) {
       break;
     }
   }
-  static_cast<void>(fclose(fp));
+  (void)fclose(fp);
 }
 
 void WriteAnnot(FPDF_PAGE page, const char* pdf_name, int num) {
@@ -343,7 +343,7 @@ void WriteAnnot(FPDF_PAGE page, const char* pdf_name, int num) {
     }
   }
 
-  static_cast<void>(fclose(fp));
+  (void)fclose(fp);
 }
 
 std::string WritePng(const char* pdf_name,
@@ -383,7 +383,7 @@ std::string WritePng(const char* pdf_name,
   if (bytes_written != png_encoding.size())
     fprintf(stderr, "Failed to write to %s\n", filename);
 
-  static_cast<void>(fclose(fp));
+  (void)fclose(fp);
   return std::string(filename);
 }
 
@@ -649,6 +649,6 @@ void WriteImages(FPDF_PAGE page, const char* pdf_name, int page_num) {
     else
       fprintf(stderr, "Successfully wrote embedded image %s.\n", filename);
 
-    static_cast<void>(fclose(fp));
+    (void)fclose(fp);
   }
 }