summaryrefslogtreecommitdiff
path: root/testing/embedder_test.cpp
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2015-07-16 10:06:11 -0700
committerLei Zhang <thestig@chromium.org>2015-07-16 10:06:11 -0700
commitba026913c273a5c1c841bced288fdab03f10ad08 (patch)
treeed0891e25899bfb38c0ccf00acfdf46cb946217a /testing/embedder_test.cpp
parent98e77014d4732e3e8c85d14169090f058f5469d3 (diff)
downloadpdfium-ba026913c273a5c1c841bced288fdab03f10ad08.tar.xz
XFA: Add a comment regarding the shut down order.
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1234323003 .
Diffstat (limited to 'testing/embedder_test.cpp')
-rw-r--r--testing/embedder_test.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/testing/embedder_test.cpp b/testing/embedder_test.cpp
index 1f3f6ef542..72b858d276 100644
--- a/testing/embedder_test.cpp
+++ b/testing/embedder_test.cpp
@@ -170,6 +170,10 @@ void EmbedderTest::SetUp() {
void EmbedderTest::TearDown() {
if (document_) {
FORM_DoDocumentAAction(form_handle_, FPDFDOC_AACTION_WC);
+
+ // Note: The shut down order here is the reverse of the non-XFA branch
+ // order. Need to work out if this is required, and if it is, the lifetimes
+ // of objects owned by |doc| that |form| reference.
FPDF_CloseDocument(document_);
FPDFDOC_ExitFormFillEnvironment(form_handle_);
}