diff options
author | Dan Sinclair <dsinclair@chromium.org> | 2018-01-03 09:44:28 -0500 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-01-08 14:52:51 +0000 |
commit | 5553d8b11634935c34e7774325eda6afd61c8f56 (patch) | |
tree | a33d4014b3c7f1ef88bf84e3ec3ef05a53af1b7f /testing/embedder_test_main.cpp | |
parent | 5183e8679844eeff2c5dda2a2e02762487429a1f (diff) | |
download | pdfium-5553d8b11634935c34e7774325eda6afd61c8f56.tar.xz |
Initialize V8 once in embedder tests
This CL moves the initialization of the V8 platform to happen in the
GTest environment so it's only run once. This takes the
CFXJSE_FormCalcContextEmbedderTest Debug time from ~25s to ~19s on my
local machine.
Bug: pdfium:928
Change-Id: Ie8c27606721e7056de42e7d9474b0621f1e7212f
Reviewed-on: https://pdfium-review.googlesource.com/22070
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'testing/embedder_test_main.cpp')
-rw-r--r-- | testing/embedder_test_main.cpp | 94 |
1 files changed, 94 insertions, 0 deletions
diff --git a/testing/embedder_test_main.cpp b/testing/embedder_test_main.cpp new file mode 100644 index 0000000000..ade6118e64 --- /dev/null +++ b/testing/embedder_test_main.cpp @@ -0,0 +1,94 @@ +// Copyright 2018 PDFium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include <string> + +#include "core/fxcrt/fx_memory.h" +#include "testing/gmock/include/gmock/gmock.h" +#include "testing/gtest/include/gtest/gtest.h" +#include "testing/test_support.h" + +#ifdef PDF_ENABLE_V8 +#include "v8/include/v8-platform.h" +#include "v8/include/v8.h" +#endif // PDF_ENABLE_v8 + +namespace { + +const char* g_exe_path = nullptr; + +#ifdef PDF_ENABLE_V8 +#ifdef V8_USE_EXTERNAL_STARTUP_DATA +v8::StartupData* g_v8_natives = nullptr; +v8::StartupData* g_v8_snapshot = nullptr; +#endif // V8_USE_EXTERNAL_STARTUP_DATA +#endif // PDF_ENABLE_V8 + +// The loading time of the CFGAS_FontMgr is linear in the number of times it is +// loaded. So, if a test suite has a lot of tests that need a font manager they +// can end up executing very, very slowly. +class Environment : public testing::Environment { + public: + void SetUp() override { +#ifdef PDF_ENABLE_V8 +#ifdef V8_USE_EXTERNAL_STARTUP_DATA + if (g_v8_natives && g_v8_snapshot) { + InitializeV8ForPDFium(g_exe_path, std::string(), nullptr, nullptr, + &platform_); + } else { + g_v8_natives = new v8::StartupData; + g_v8_snapshot = new v8::StartupData; + InitializeV8ForPDFium(g_exe_path, std::string(), g_v8_natives, + g_v8_snapshot, &platform_); + } +#else + InitializeV8ForPDFium(g_exe_path, &platform_); +#endif // V8_USE_EXTERNAL_STARTUP_DATA +#endif // FPDF_ENABLE_V8 + } + + void TearDown() override { +#ifdef PDF_ENABLE_V8 + v8::V8::ShutdownPlatform(); + delete platform_; +#endif // PDF_ENABLE_V8 + } + + private: +#ifdef PDF_ENABLE_V8 + v8::Platform* platform_; +#endif // PDF_ENABLE_V8 +}; + +Environment* env_ = nullptr; + +} // namespace + +// Can't use gtest-provided main since we need to stash the path to the +// executable in order to find the external V8 binary data files. +int main(int argc, char** argv) { + g_exe_path = argv[0]; + + FXMEM_InitializePartitionAlloc(); + + env_ = new Environment(); + // The env will be deleted by gtest. + AddGlobalTestEnvironment(env_); + + testing::InitGoogleTest(&argc, argv); + testing::InitGoogleMock(&argc, argv); + + int ret_val = RUN_ALL_TESTS(); + +#ifdef PDF_ENABLE_V8 +#ifdef V8_USE_EXTERNAL_STARTUP_DATA + if (g_v8_natives) + free(const_cast<char*>(g_v8_natives->data)); + if (g_v8_snapshot) + free(const_cast<char*>(g_v8_snapshot->data)); +#endif // V8_USE_EXTERNAL_STARTUP_DATA +#endif // PDF_ENABLE_V8 + + return ret_val; +} |