diff options
| author | tsepez <tsepez@chromium.org> | 2016-08-15 16:44:55 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-08-15 16:44:55 -0700 |
| commit | b4694249b336d1c0bea9222880b49dcf9284791d (patch) | |
| tree | 681a503d12000b78296bcacf4fce046922335950 /testing/js_embedder_test.h | |
| parent | 19cdfe4d73370b21709aefd9dce06cf463239fa1 (diff) | |
| download | pdfium-b4694249b336d1c0bea9222880b49dcf9284791d.tar.xz | |
Push v8::Isolate into CFXJS_Engine classchromium/2831
Nearly all the "loose" functions in FXJS become methods on
the CFJXS_Engine.
This is the "missing link" wrt some layering violatons that
have been around forever. We can stop passing &m_ variables
from CJS_ down into FXJS Initialization as a result.
Review-Url: https://codereview.chromium.org/2245863002
Diffstat (limited to 'testing/js_embedder_test.h')
| -rw-r--r-- | testing/js_embedder_test.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/testing/js_embedder_test.h b/testing/js_embedder_test.h index b2bd5a87b1..f0beb1eb29 100644 --- a/testing/js_embedder_test.h +++ b/testing/js_embedder_test.h @@ -21,12 +21,12 @@ class JSEmbedderTest : public EmbedderTest { v8::Isolate* isolate(); v8::Local<v8::Context> GetV8Context(); + CFXJS_Engine* engine() { return m_Engine.get(); } private: std::unique_ptr<FXJS_ArrayBufferAllocator> m_pArrayBufferAllocator; v8::Isolate* m_pIsolate; - v8::Global<v8::Context> m_pPersistentContext; - std::vector<v8::Global<v8::Object>*> m_StaticObjects; + std::unique_ptr<CFXJS_Engine> m_Engine; }; #endif // TESTING_JS_EMBEDDER_TEST_H_ |