Fix behaviour of app.alert() with a single object argument.

Centralize the "arguments in an object" logic.  See the section
"Method Arguments" in the js_api_reference.pdf.  Add some tests
to hit the ambiguous cases this section implies, and test that
all parameters are passed end-to-end to our callbacks.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1641693003 .

1 files changed, 26 insertions, 0 deletions

diff --git a/testing/resources/javascript/app_alert.in b/testing/resources/javascript/app_alert.in
index de6c8a8229..75aecc9075 100644
--- a/testing/resources/javascript/app_alert.in
+++ b/testing/resources/javascript/app_alert.in
@@ -35,6 +35,32 @@ endobj
 >>
 stream
 app.alert("This test passes if alert() logs output under the test utility.");
+app.alert("message", 1, 2, "title");
+app.alert({"cMsg": "message", "cTitle": "title"});
+app.alert({"cMsg": "message", "cTitle": "title", "nIcon": 3, "nType": 4});
+app.alert(undefined);
+app.alert(null);
+app.alert(true);
+app.alert(false);
+app.alert(42);
+app.alert([1, 2, 3]);
+app.alert([1, 2, {"color": "red"}]);
+app.alert({"color": "red"}, 5, 6, "title"); 
+try {
+  app.alert();
+} catch (e) {
+  app.alert("Caught expected error " + e);
+}
+try {
+  app.alert({});
+} catch (e) {
+  app.alert("Caught expected error " + e);
+}
+try {
+  app.alert({"color": "red", "size": 42});
+} catch (e) {
+  app.alert("Caught expected error " + e);
+}
 endstream
 endobj
 {{xref}}