diff options
| author | tonikitoo <tonikitoo@igalia.com> | 2016-08-19 11:18:29 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-08-19 11:18:29 -0700 |
| commit | bb5fa043a7ef2de165c7903548e5663a6f8bcf9a (patch) | |
| tree | 97d7fcec70171f9d12d2d613486e140d72eb1baa /testing/resources/javascript | |
| parent | fb606f2723b87a145a9ceece6cd6ccaaf15ceadd (diff) | |
| download | pdfium-bb5fa043a7ef2de165c7903548e5663a6f8bcf9a.tar.xz | |
Stub out Document::syncAnnotScan method.chromium/2834
The PDF specification [1] says:
"
syncAnnotScan guarantees that all annotations will be scanned
by the time this method returns.
(..)
Normally a background task runs that examine every page and
looks for annotations during idle times.
"
The statement details specifically how Acrobat implements
this method.
Although, neither the method itself nor the background scanner
task are implemented in PDFium (as of today, Ago/2016),
not having ::syncAnnotScan at least stubbed out can be considered
harmfull since its absence makes JS acrobat scripts silently
fail when it has a call to it.
Given that, and following a stub-out pattern present in other
methods including ::addAnnot and ::addField, CL provides
a stubbed out implementation of Document::syncAnnotScan.
[1] http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/js_api_reference.pdf
BUG=pdfium:492
Review-Url: https://codereview.chromium.org/2265553002
Diffstat (limited to 'testing/resources/javascript')
| -rw-r--r-- | testing/resources/javascript/document_methods.in | 1 | ||||
| -rw-r--r-- | testing/resources/javascript/document_methods_expected.txt | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/testing/resources/javascript/document_methods.in b/testing/resources/javascript/document_methods.in index bc0f3f1126..cdbd6845c8 100644 --- a/testing/resources/javascript/document_methods.in +++ b/testing/resources/javascript/document_methods.in @@ -314,6 +314,7 @@ try { testUnsupported('this.removeIcon'); testUnsupported('this.replacePages'); testUnsupported('this.saveAs'); + testUnsupported('this.syncAnnotScan'); app.alert('*** Testing Supported Methods ***'); testAddIcon(); diff --git a/testing/resources/javascript/document_methods_expected.txt b/testing/resources/javascript/document_methods_expected.txt index ed601f279b..70a7481708 100644 --- a/testing/resources/javascript/document_methods_expected.txt +++ b/testing/resources/javascript/document_methods_expected.txt @@ -68,6 +68,9 @@ Alert: PASS: this.replacePages(1, 2, "clams", [1, 2, 3]) = undefined Alert: PASS: typeof this.saveAs = function Alert: PASS: this.saveAs() = undefined Alert: PASS: this.saveAs(1, 2, "clams", [1, 2, 3]) = undefined +Alert: PASS: typeof this.syncAnnotScan = function +Alert: PASS: this.syncAnnotScan() = undefined +Alert: PASS: this.syncAnnotScan(1, 2, "clams", [1, 2, 3]) = undefined Alert: *** Testing Supported Methods *** Alert: PASS: typeof this.addIcon = function Alert: PASS: this.addIcon() threw error Document.addIcon: Incorrect number of parameters passed to function. |