diff options
| author | Andreas Haas <ahaas@chromium.org> | 2018-02-05 18:32:18 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-05 18:32:18 +0000 |
| commit | 608e8dd6b87b15772862dca9b7b2e6791a25dab6 (patch) | |
| tree | 384dbec190cf8a7901af8dd1cdb37aafac10766a /testing/test_support.h | |
| parent | a21d593e202cbef9a0641d0123917ac3b8d73ee6 (diff) | |
| download | pdfium-608e8dd6b87b15772862dca9b7b2e6791a25dab6.tar.xz | |
[v8-platform] Store the platform in a unique_ptr
We want to change the signature of {CreateDefaultPlatform} in the V8
API to return a unique_ptr instead of a raw pointer to indicate that the
caller owns the platform. With this change we prepare pdfium for this
change.
R=thestig@chromium.org
Change-Id: I4a0a466dfc37b28387a91543623a7a481ca8035a
Reviewed-on: https://pdfium-review.googlesource.com/18191
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'testing/test_support.h')
| -rw-r--r-- | testing/test_support.h | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/testing/test_support.h b/testing/test_support.h index ec4b4aeacb..1b7692c3ed 100644 --- a/testing/test_support.h +++ b/testing/test_support.h @@ -91,14 +91,14 @@ class Platform; namespace v8 { class StartupData; } -bool InitializeV8ForPDFium(const std::string& exe_path, - const std::string& bin_dir, - v8::StartupData* natives_blob, - v8::StartupData* snapshot_blob, - v8::Platform** platform); +std::unique_ptr<v8::Platform> InitializeV8ForPDFium( + const std::string& exe_path, + const std::string& bin_dir, + v8::StartupData* natives_blob, + v8::StartupData* snapshot_blob); #else // V8_USE_EXTERNAL_STARTUP_DATA -bool InitializeV8ForPDFium(const std::string& exe_path, - v8::Platform** platform); +std::unique_ptr<v8::Platform> InitializeV8ForPDFium( + const std::string& exe_path); #endif // V8_USE_EXTERNAL_STARTUP_DATA #endif // PDF_ENABLE_V8 |