diff options
| author | dan sinclair <dsinclair@chromium.org> | 2017-01-30 19:48:54 -0800 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-01-31 17:44:30 +0000 |
| commit | 00d4064e5414fc0845e354b50c7f1a8323449268 (patch) | |
| tree | cd1016cf5ce85dda2028f93531f298259b5e94a8 /testing/tools/suppressor.py | |
| parent | 576e8151efab01166142ec697b66ce38b7bf6780 (diff) | |
| download | pdfium-00d4064e5414fc0845e354b50c7f1a8323449268.tar.xz | |
Fixup test harness
When the results of the test runner were converted to return a tuple the
following code which checked the results for true/false were not updated
to extract the success value from the tuple. This caused the code to think
that the results always passed even when they failed.
This CL fixes the two tests which were broken (both just minor image result
differences) which slipped in during this breakage.
Change-Id: I01b56dd7b05013c2c12c83543746cf59b145e561
Reviewed-on: https://pdfium-review.googlesource.com/2456
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'testing/tools/suppressor.py')
| -rwxr-xr-x | testing/tools/suppressor.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/testing/tools/suppressor.py b/testing/tools/suppressor.py index b7629ef6f8..86d2668adb 100755 --- a/testing/tools/suppressor.py +++ b/testing/tools/suppressor.py @@ -12,8 +12,10 @@ class Suppressor: feature_vector = feature_string.strip().split(",") self.has_v8 = "V8" in feature_vector self.has_xfa = "XFA" in feature_vector + self.is_asan = "ASAN" in feature_vector v8_option = "v8" if self.has_v8 else "nov8" xfa_option = "xfa" if self.has_xfa else "noxfa" + with open(os.path.join(finder.TestingDir(), 'SUPPRESSIONS')) as f: self.suppression_set = set(self._FilterSuppressions( common.os_name(), v8_option, xfa_option, self._ExtractSuppressions(f))) @@ -31,6 +33,8 @@ class Suppressor: os_column = item[1].split(","); js_column = item[2].split(","); xfa_column = item[3].split(","); + if self.is_asan and 'asan' in os_column: + return True return (('*' in os_column or os in os_column) and ('*' in js_column or js in js_column) and ('*' in xfa_column or xfa in xfa_column)) |